Summary: | net/pecl-geoip: Unbreak with PHP 7.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Hung-Yi Chen <gaod> | ||||
Component: | Individual Port(s) | Assignee: | Po-Chuan Hsieh <sunpoet> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | rm | ||||
Priority: | --- | Keywords: | patch | ||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(sunpoet) |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Thanks for the patch. If I may suggest, it would be very helpful to submit patches against the svn tree (to have a patch that creates a patch) as that gives a better change context and makes resolving issues easier and faster. Can you confirm this builds fine and passes tests? Are these fixes available or submitted upstream? Cleaning up summary in favor of PR keywords. A commit references this bug: Author: sunpoet Date: Sun Jun 26 17:24:17 UTC 2016 New revision: 417589 URL: https://svnweb.freebsd.org/changeset/ports/417589 Log: - Fix build with PHP 7.0 PR: 210003 Submitted by: Hung-Yi Chen <gaod@hychen.org> Changes: head/net/pecl-geoip/Makefile head/net/pecl-geoip/files/ head/net/pecl-geoip/files/patch-geoip.c head/net/pecl-geoip/files/patch-php_geoip.h Proposed fix was committed, close. |
Created attachment 170988 [details] net_pecl-geoip.patch * Make net/pecl-geoip can compile with PHP 7.0.