Bug 210096

Summary: audio/hydrogen-devel remove wrongly used PLIST_SUB from pkg-plist
Product: Ports & Packages Reporter: Tobias Berner <tcberner>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me CC: FreeBSD
Priority: --- Flags: FreeBSD: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
s#%%QT_BINDIR%%#bin#g none

Description Tobias Berner 2016-06-07 11:25:01 UTC
Created attachment 171137 [details]
s#%%QT_BINDIR%%#bin#g

audio/hydrogen-devel uses the substitution %%QT_BINDIR%% [=relative path to Qt binaries] by mistake.
The attached patch replaces this everywhere by "bin".
Comment 1 Shane 2016-06-08 08:45:50 UTC
(In reply to Tobias Berner from comment #0)

Tobias, not sure if you have it on your list but I also see s#%%CMAKE_BUILD_TYPE%%#release#g as another bad substitute that has been missed in several ports.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-06-08 12:57:28 UTC
A commit references this bug:

Author: amdmi3
Date: Wed Jun  8 12:57:01 UTC 2016
New revision: 416539
URL: https://svnweb.freebsd.org/changeset/ports/416539

Log:
  - Fix misused PLIST_SUB substitudes [1]
  - While here, fix license, whitespace, add missing qt corelib dependency and switch to new test framework [2]

  PR:		210096 [1]
  Submitted by:	tcberner@gmail.com [1]
  Approved by:	FreeBSD@ShaneWare.Biz [1], portmgr blanket [2]

Changes:
  head/audio/hydrogen-devel/Makefile
  head/audio/hydrogen-devel/pkg-plist