Summary: | java/openjdk8: Fix for OpenJDK Network Crash (regression of PR 175417) | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Andrew Smith <iamasmith.home> | ||||
Component: | Individual Port(s) | Assignee: | freebsd-java (Nobody) <java> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Some People | CC: | glewis, huanghwh | ||||
Priority: | --- | Keywords: | patch | ||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(java) |
||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Andrew Smith
2016-06-10 13:57:16 UTC
Created attachment 171267 [details]
patch_bsd_close_jdk8
Noting for future reference and porting effort that bsd-ports/jdk9 has bsd_close here src/java.base/macosx/native/libnet/bsd_close.c and it also lacks the conditional change back to poll. I'm not sure if I missed some etiquette here but not that you have removed [PATCH] from the title which I had previously considered helpful to a maintainer finding a patch on the PR and seems to be common place. Not changing it back of course if there is a reason why we shouldn't keep some additional cue's in the title of the article to help folks who often have a day job as well as put effort into maintaining these ports. Just out of curiosity, are you using Akka in the Scala apps..? I need to finish my due diligence piece on that so I'm kinda' interested and have heard of some interesting stability concerns re sun.misc.Unsafe and Akka providing their own..? Previous comment misplayed related to anther bug thread. Apologies This patch also bug Bug 208553. Seems effects some additonal PRs so change to 'Some People' from self. A commit references this bug: Author: glewis Date: Sun Jun 12 21:56:01 UTC 2016 New revision: 416826 URL: https://svnweb.freebsd.org/changeset/ports/416826 Log: . Use poll() rather than select() on BSD to avoid crashes during network timeouts. This is forwarded ported from OpenJDK 7. . Bump PORTREVISION for this fix. PR: 210191 Submitted by: Andrew Smith <iamasmith.home@gmail.com> Changes: head/java/openjdk8/Makefile head/java/openjdk8/files/patch-jdk-src-solaris-native-java-net-bsd_close.c I've committed this change to the openjdk8 port. Leaving it open while I get it into the openjdk8 upstream and openjdk9 upstream. I think openjdk9 actually has some issues on where to get this in. The bsd_close.c file there is only part of the MacOS X build now. We'll need some additional work to pull it in. I can get it into the openjdk8 upstream though, since it is just a forward port from openjdk7. My OCA has been processed and I now appear on the OCA web page as 'Andrew Smith - OpenJDK' and am happy for you to sponsor these changes should you wish. -Andy This has been pushed upstream. Thanks Andrew! |