Bug 210582

Summary: net-im/pidgin-skypeweb: No longer able to connect
Product: Ports & Packages Reporter: Dmitri Goutnik <dmgk>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed Overcome By Events    
Severity: Affects Only Me CC: dmgk, sepulkarium45
Priority: --- Keywords: easy, patch
Version: LatestFlags: vlad-fbsd: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Backport upstream fixes dmgk: maintainer-approval+

Description Dmitri Goutnik freebsd_committer freebsd_triage 2016-06-26 00:38:33 UTC 
Most likely the same issue as described in https://github.com/EionRobb/skype4pidgin/issues/449

Is it possible to update port to https://github.com/EionRobb/skype4pidgin/commit/72f0b003252d0c827e9fa5dcb31005ef4a51b036 to get this resolved?
Comment 1 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-04 02:20:14 UTC 
Created attachment 172083 [details]
Backport upstream fixes

Backport upstream fixes.

Relevant commits from master:

- 72f0b00: Functionerize the plain http request code to get it working (hackily)… [1]
- f23913d: Silence critics - hide json-glib 'critical' errors [2]

[1] https://github.com/EionRobb/skype4pidgin/commit/72f0b003252d0c827e9fa5dcb31005ef4a51b036
[2] https://github.com/EionRobb/skype4pidgin/commit/f23913d1287ab212aa2c3cd32eda64555a49281b
Comment 2 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-04 02:30:03 UTC 
poudriere testport 10.3-RELEASE-p5 amd64: http://poudriere.syrec.org/pidgin-skypeweb/1.1_1%2C1/10amd64-default.log
Comment 3 Andrey Akhmichin 2016-07-04 14:22:05 UTC 
Sorry for the waiting time.
Your patch works for me.
Thanks!
Comment 4 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-05 01:02:47 UTC 
Hi Andrey,

Could you please also set maintainer-approval+ on the attached patch so the commiters will see it in the "Maintainer approved" search.
Comment 5 Andrey Akhmichin 2016-07-05 12:22:52 UTC 
Comment on attachment 172083 [details]
Backport upstream fixes

Ready!
Comment 6 Andrey Akhmichin 2016-07-05 13:00:24 UTC 
Comment on attachment 172083 [details]
Backport upstream fixes

Dmitri, It seems I can't change it.
Comment 7 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-05 14:18:11 UTC 
Sorry, turns out I was a "maintainer" of this patch.
Comment 8 VK 2016-07-09 00:12:46 UTC 
Thanks for your effort guys.

Dmitri, yes, when requesting maintainer-approval(?), and btw maintainer-feedback(?) too, you have to specify the maintainer email address, otherwise Bugzilla has no means to allow who can flag it.

Please confirm these changes pass QA (portlint, poudriere).
Comment 9 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-09 01:27:20 UTC 
portlint -AC: OK

poudriere testport 10.3-RELEASE-p5 amd64: OK [1]
poudriere testport 9.3-RELEASE-p44 amd64: OK [2]

[1] http://poudriere.syrec.org/pidgin-skypeweb/1.1_1%2C1/10amd64-default.log
[2] http://poudriere.syrec.org/pidgin-skypeweb/1.1_1%2C1/9amd64-default.log
Comment 10 Dmitri Goutnik freebsd_committer freebsd_triage 2016-07-19 19:02:49 UTC 
Obsoleted by bug #211234