Bug 210610

Summary:

update graphics/imlib2_loaders to 1.4.9

Product:

Ports & Packages

Reporter:

Walter Schwarzenfeld <w.schwarzenfeld>

Component:

Individual Port(s)

Assignee:

Niclas Zeising <zeising>

Status:

Closed FIXED

Severity:

Affects Many People

CC:

pi, zeising

Priority:

---

Flags:

zeising: maintainer-feedback+

Version:

Latest

Hardware:

Any

OS:

Any

Bug Depends on:

210609

Bug Blocks:

Attachments:

Description	Flags
svn-diff_graphics_imlib2_loaders	none
svn-diff_graphics_imlib2_loaders_new	none
svn-diff_graphics_imlib2_loaders_corr	none
Extended patch	none

Description Walter Schwarzenfeld freebsd_triage

2016-06-27 04:39:52 UTC

Created attachment 171850 [details]
svn-diff_graphics_imlib2_loaders

ChangeLog:
Tells no significant changes.

Update only for version sync with imlib2.

portlint OK.

Maintainer maybe resetted (see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210474)

Comment 1 Walter Schwarzenfeld freebsd_triage

2016-06-27 06:41:12 UTC

Poudriere builds OK for 103amd64 and 93amd64.

Comment 2 Dmitry Marakasov freebsd_committer

2016-06-27 18:35:27 UTC

Extra comment line is not needed. Also, does it not build with clang? I'd prefer more relaxed compiler requirements if possible, like (if it actually builds with clang)

.if ${CHOSEN_COMPILER_TYPE} == gcc
USE_GCC=       4.9+
.endif

Comment 3 Walter Schwarzenfeld freebsd_triage

2016-06-27 19:54:13 UTC

Extra comment line, cause of an statement of of portlint. If it is not needed should removed from portlint. But I can change it.
Does not build with clang with the port (not tested with poudriere yet).

----
Poudriere builds OK with 93amd64 and 93i386.

Comment 4 Rene Ladan freebsd_committer

2016-06-27 21:48:12 UTC

Maintainer reset.

Comment 5 Walter Schwarzenfeld freebsd_triage

2016-06-27 22:40:56 UTC

Created attachment 171893 [details]
svn-diff_graphics_imlib2_loaders_new

Comment 6 Walter Schwarzenfeld freebsd_triage

2016-06-27 23:01:20 UTC

Created attachment 171894 [details]
svn-diff_graphics_imlib2_loaders_corr

Correct maintainer.

Comment 7 Walter Schwarzenfeld freebsd_triage

2016-06-28 19:54:07 UTC

The port has a new maintainer zeising@FreeBSD.org-

Comment 8 Walter Schwarzenfeld freebsd_triage

2016-06-28 19:54:36 UTC

The port has a new maintainer zeising@FreeBSD.org-

Comment 9 Dmitry Marakasov freebsd_committer

2016-06-29 19:55:19 UTC

Created attachment 171955 [details]
Extended patch

I propose this extended patch.

- Add missing xorg depends
- Switch to options helpers
- Switch to USES=localbase

Comment 10 Niclas Zeising freebsd_committer

2016-06-29 20:12:37 UTC

Thanks for the patch!
I'll look into this tomorrow, but from a cursory glance it looks good.

Comment 11 commit-hook freebsd_committer

2016-06-30 20:39:33 UTC

A commit references this bug:

Author: zeising
Date: Thu Jun 30 20:38:37 UTC 2016
New revision: 417841
URL: https://svnweb.freebsd.org/changeset/ports/417841

Log:
  Update o 1.4.9

  Switch to use options helpers
  Add missing dependencies
  USES=localbase instead of handrolling
  use install-strip instead of handrolling

  PR:		210610
  Submitted by:	Dmitry Marakasov (amdmi3)
  Reported by:	w.schwarzenfeld@utanet.at

Changes:
  head/graphics/imlib2_loaders/Makefile
  head/graphics/imlib2_loaders/distinfo

Comment 12 Niclas Zeising freebsd_committer

2016-06-30 20:39:58 UTC

Committed. Thanks for all patches!