Bug 210631

Summary: devel/staf: Add DOCS, EXAMPLES, JAVA and PERL options
Product: Ports & Packages Reporter: Alan Somers <asomers>
Component: Individual Port(s)Assignee: Alan Somers <asomers>
Status: Closed FIXED    
Severity: Affects Only Me CC: brd, skozlov
Priority: --- Keywords: needs-qa, patch
Version: LatestFlags: bugzilla: maintainer-feedback? (skozlov)
Hardware: Any   
OS: Any   
URL: https://reviews.freebsd.org/D6910
Attachments:
Description Flags
Bugzilla feedback and approval flags none

Description Alan Somers freebsd_committer freebsd_triage 2016-06-27 15:31:13 UTC 
Add options for DOCS, EXAMPLES, JAVA and PERL. The JAVA option enables all JAVA-based STAF services that don't have additional dependencies. Also add a symlink from FmtLog to fmtlog.

The patch is in Phabricator at https://reviews.freebsd.org/D6910
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-27 15:38:33 UTC 
@Alan, currently non-committers are not assigned issues. If you plan to commit this yourself, please feel free to self-assign
Comment 2 Alan Somers freebsd_committer freebsd_triage 2016-06-27 15:55:25 UTC 
@kubilay I plan to commit it myself, but I assigned it to Sergey to request maintainer feedback first.  What's the best way to request maintainer feedback?
Comment 3 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-27 16:06:59 UTC 
Created attachment 171876 [details]
Bugzilla feedback and approval flags
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-27 16:07:24 UTC 
(In reply to Alan Somers from comment #2)

When "category/port:" is used in an issues summary, the maintainer (or maintainers) (if the port(s) are maintained), is automatically added to the "maintainer-feedback" flag (or flags) and notified.

Since you'll be committing, feel free to assign yourself :)

To mark acceptance of a change, a maintainer (in this case Sergey), can either accept a review in phabricator if they have an account, or in most cases, set the maintainer-approval flag value (on the patch attachment) to +
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2016-06-27 16:08:31 UTC 
See screenshot in attachment 171876 [details] for maintainer-feedback (issue level) and maintainer-approval (attachment level) flag locations.

Hope that helps :)
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-07-15 23:20:51 UTC 
A commit references this bug:

Author: asomers
Date: Fri Jul 15 23:20:15 UTC 2016
New revision: 418611
URL: https://svnweb.freebsd.org/changeset/ports/418611

Log:
  Add DOCS, EXAMPLES, JAVA and PERL options to devel/staf

  devel/staf/Makefile
  	Add options for DOCS, EXAMPLES, JAVA and PERL. The JAVA option
  	enables all JAVA-based STAF services that don't have additional
  	dependencies. Also add a symlink from FmtLog to fmtlog.  Also update
  	the USE_OPENSSL syntax to USES=ssl.

  PR:		210631
  Submitted by:	asomers, Sergey Kozlov
  Reviewed by:	Sergey Kozlov
  Approved by:	brd (ports)
  Sponsored by:	Spectra Logic Corp
  Differential Revision:	https://reviews.freebsd.org/D6910

Changes:
  head/devel/staf/Makefile
  head/devel/staf/pkg-plist