Bug 210637
| Summary: | archivers/gtar: remove unused flags, fix license | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | Flags: | naddy:
maintainer-feedback+
|
||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Created attachment 171882 [details]
Patch
Well, with regard to removing CPPFLAGS/LDFLAGS:
* I had to check what happens with libiconv on 9.x. (USES=iconv appears to handle it.)
* I had to check if libintl is still picked up. (It is. Probably from --prefix.)
* There still is a resulting configure difference...
checking whether readlink handles trailing slash correctly... yes
checking whether readlinkat signature is correct... yes
checking for working re_compile_pattern... no
-checking libintl.h usability... yes
-checking libintl.h presence... yes
-checking for libintl.h... yes
+checking libintl.h usability... no
+checking libintl.h presence... no
+checking for libintl.h... no
checking whether isblank is declared... (cached) yes
checking whether rename honors trailing slash on destination... yes
checking whether rename honors trailing slash on source... yes
... and because of this gnu/regex.o is built differently. I haven't examined in detail if the difference is meaningful.
Can't we just leave CPPFLAGS/LDFLAGS in place?
The license and ${TOUCH} changes are fine.
(In reply to Christian Weisgerber from comment #2) > Can't we just leave CPPFLAGS/LDFLAGS in place? Ok, but let's instead change it to USES=localbase Created attachment 171945 [details]
Patch
Sure, ok. A commit references this bug: Author: amdmi3 Date: Wed Jun 29 15:27:31 UTC 2016 New revision: 417776 URL: https://svnweb.freebsd.org/changeset/ports/417776 Log: - Fix license - Switch to USES=localbase - Switch to ${TOUCH} PR: 210637 Approved by: naddy@FreeBSD.org (maintainer) Changes: head/archivers/gtar/Makefile |
- Remove useless CPPFLAGS/LDFLAGS, this does not seem to use any ports' depends - Fix license - Use ${TOUCH}