Bug 210674

Summary:

print/cloudprint: Missing dependencies (requests, argparse)

Product:

Ports & Packages

Reporter:

Jochen Breuer <brejoc>

Component:

Individual Port(s)

Assignee:

Bernhard Froehlich <decke>

Status:

Closed FIXED

Severity:

Affects Many People

CC:

decke, emaste, koobs, python

Priority:

---

Keywords:

easy, patch

Version:

Latest

Flags:

koobs: maintainer-feedback+
koobs: merge-quarterly-

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Patch that adds the missing dependendies for requests and argparse	none
Updated patch with version bump of PORTVERSION	koobs: maintainer-approval+

Description Jochen Breuer 2016-06-28 21:20:39 UTC

I've installed cloudprint via pkg on FreeBSD 10.3.

Starting cloudprint fails due to missing dependendies:

> pkg_resources.DistributionNotFound: The 'requests>=2.7.0' distribution was not found and is required by cloudprint

… and …

> pkg_resources.DistributionNotFound: The 'argparse' distribution was not found and is required by cloudprint

After installing py27-requests and py27-argparse cloudprint seems to work. These dependencies do not seem to be optional.

Comment 1 Jochen Breuer 2016-06-29 17:23:01 UTC

The setup.py[1] of cloudprint also mentions the two dependencies:

>    …
>    install_requires=[
>        'argparse',
>        'pycups',
>        'requests >= 2.7.0',
>    ],
>    …


[1] https://raw.githubusercontent.com/armooo/cloudprint/master/setup.py

Comment 2 Jochen Breuer 2016-07-11 18:57:26 UTC

Created attachment 172388 [details]
Patch that adds the missing dependendies for requests and argparse

Patch is auto-generated via GitHub. I hope that's okay.
https://github.com/brejoc/freebsd-ports/commit/aaf52d585e537441350881523758fab7ec5e5093.patch

Comment 3 Kubilay Kocak freebsd_committer

2016-07-12 08:37:01 UTC

Patch  looks good apart from a missing PORTREVISION bump (set it to 1 if it doesn't exist, else increment)

Comment 4 Jochen Breuer 2016-07-12 09:35:42 UTC

Created attachment 172404 [details]
Updated patch with version bump of PORTVERSION

Patch now also includes the incremented PORTVERSION.

Comment 5 Ed Maste freebsd_committer

2016-08-15 10:15:44 UTC

As this is reported on FreeBSD 10.3 hardware must not be arm64. Updated to 'Any' as it is not obviously arch-specific.

Comment 6 Kubilay Kocak freebsd_committer

2016-08-15 13:25:25 UTC

Comment on attachment 172404 [details]
Updated patch with version bump of PORTVERSION

Maintainer timeout (>1 month), implicit approval

Comment 7 Kubilay Kocak freebsd_committer

2016-08-15 13:25:54 UTC

Open to take

Comment 8 commit-hook freebsd_committer

2016-11-16 16:18:50 UTC

A commit references this bug:

Author: decke
Date: Wed Nov 16 16:18:28 UTC 2016
New revision: 426248
URL: https://svnweb.freebsd.org/changeset/ports/426248

Log:
  - Add missing runtime dependencies (requests, argparse)
  - Bump PORTREVISION

  PR:		210674
  Submitted by:	Jochen Breuer <brejoc@gmail.com>

Changes:
  head/print/cloudprint/Makefile

Comment 9 Bernhard Froehlich freebsd_committer

2016-11-16 16:19:44 UTC

Committed. Thanks a lot for the patch and sorry for the long delay!

Comment 10 Kubilay Kocak freebsd_committer

2016-11-17 01:13:37 UTC

Assign to resolving committer