Bug 21070

Summary: default setting of ${SUP} in Makefile.inc1 doesn't work
Product: Base System Reporter: Tony Finch <dot>
Component: miscAssignee: Marcel Moolenaar <marcel>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 4.1-STABLE   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Tony Finch 2000-09-06 02:30:01 UTC 
cvsup is usually installed in /usr/local/bin
/usr/src/Makefile sets the PATH to /sbin:/bin:/usr/sbin:/usr/bin
before running Makefile.inc1
/usr/src/Makefile.inc1 sets SUP to just "cvsup" if it isn't already set

The result of all this is not as helpful as it tries to be.

How-To-Repeat: 
Run `make update` with a make.conf containing a definition of SUPFILE but
no definition of SUP. Make will then bomb when it fails to find cvsup.
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 2000-09-06 13:58:18 UTC 
Responsible Changed
From-To: freebsd-bugs->marcel

Marcel restricted the PATH in rev 1.232.  The ideal solution here 
is for both bsd.port.mk and Makefile to include some other .mk file 
that provides a default definition of LOCALBASE.  Then we can 
use ${LOCALBASE}/bin/cvsup as the default value for SUP.
Comment 2 Marcel Moolenaar freebsd_committer freebsd_triage 2004-02-14 06:03:07 UTC 
State Changed
From-To: open->closed

This was fixed in rev. 1.223 of Makefile.inc and MFC'd to rev. 1.141.2.35. 
The PR mentioned in the commit log is 31932. A duplicate therefore.