Bug 210721
| Summary: | Rerooting to an imported ZFS pool triggers panic | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Jan Bramkamp <crest_maintainer> | ||||||
| Component: | kern | Assignee: | Andriy Gapon <avg> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | avg, joakimas, wheelcomplex | ||||||
| Priority: | --- | ||||||||
| Version: | CURRENT | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Jan Bramkamp
2016-06-30 09:25:56 UTC
Rerooting in place without changing vfs.root.mountfrom triggers a panic as well. I ran across this too when trying out stuff. In the end it doesn't affect my use case of rerooting from one pool to another, but I was stumped and wondered why the simplest use case of just rerooting in place didn't work. (In reply to Joakim Asplund from comment #2) Essentially, it's because the code that handles a zfs root filesystem mindlessly tries to import its pool and that's a problem if the pool is already imported. It should be very easy to fix this bug by just adding a check for that condition. Created attachment 183449 [details]
proposed patch
Could you please try this patch?
*** Bug 220916 has been marked as a duplicate of this bug. *** In my case(https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220916), rerooting to an dataset which is part of an exported zpool still trigger panic. The key point to reproducing is the zpool has been imported for some reasons. This pool has been exported befor kenv vfs.root.mountfrom=zfs:tank/dataset && reboot -r. Moreover, I reroot from a md_root to a zfs pool in local device so I can export the pool befor reroot. It's still the same underlying issue. (In reply to David NewHamlet from comment #6) I see now that my patch is incomplete, I'll update it to handle your case as well. Thank you for the report! (In reply to David NewHamlet from comment #6) For what it's worth, I can not reproduce the problem if I export the target pool before reboot -r. I am not sure why you have the problem that you have and how patch from bug #220916 could change anything. zpool export does all of spa_unload + spa_deactivate + spa_remove. (In reply to Andriy Gapon from comment #10) Thanks for your investigation. Now I also can not reproduce the problem if I export the target pool before reboot -r(after half of the day in git reverting and compiling). Sorry for the misguiding. A commit references this bug: Author: avg Date: Tue Jul 25 13:17:06 UTC 2017 New revision: 321471 URL: https://svnweb.freebsd.org/changeset/base/321471 Log: spa_import_rootpool should be able to handle an imported root pool That is required to support reboot -r with a new root filesystem being on an already imported pool. PR: 210721 Reported by: Jan Bramkamp <crest_maintainer@rlwinm.de> MFC after: 2 weeks Changes: head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c (In reply to commit-hook from comment #12) Is there any chance to get this into the upcoming 11.1 release? A commit references this bug: Author: avg Date: Tue Sep 19 08:43:16 UTC 2017 New revision: 323746 URL: https://svnweb.freebsd.org/changeset/base/323746 Log: MFC r321471: spa_import_rootpool should be able to handle an imported root pool That is required to support reboot -r with a new root filesystem being on an already imported pool. PR: 210721 Changes: _U stable/11/ stable/11/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c A commit references this bug: Author: avg Date: Tue Sep 19 08:43:46 UTC 2017 New revision: 323747 URL: https://svnweb.freebsd.org/changeset/base/323747 Log: MFC r321471: spa_import_rootpool should be able to handle an imported root pool That is required to support reboot -r with a new root filesystem being on an already imported pool. PR: 210721 Changes: _U stable/10/ stable/10/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/spa.c Is there a chance to get this into the next batch of 11.1 erratas? (In reply to Jan Bramkamp from comment #16) I am not planning to work on an erratum myself. Maybe another developer or someone from re@ would could be interested.. |
