Bug 210763
| Summary: | chinese/opencc: Update to 1.0.4 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Iblis Lin <iblis.dif01> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | lichray, pi | ||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||
| Version: | Latest | Flags: | lichray:
maintainer-feedback+
|
||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| See Also: |
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210781 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=210840 |
||||||||||||||
| Bug Depends on: | |||||||||||||||
| Bug Blocks: | 210781 | ||||||||||||||
| Attachments: |
|
||||||||||||||
There are ports relying the shared library, please fix. (In reply to lichray from comment #1) This patch include a OPTION `STATIC` to let user choose to build share lib or not. So... Do you want to remove this option? (In reply to Iblis Lin from comment #2) I see. I'll give it a test later. (In reply to Iblis Lin from comment #2) This version breaks bsdconv-opencc. I'm unable to approve it. It seems that static and shared libraries are mutual exclusive. I expect the shared library is always being built (or just remove this option, if making this optional is not a common practice in the ports tree), as fcitx is a major "customer" in the ports using opencc; building opencc without shared library is surprising IMO. Created attachment 172060 [details] opencc patch v2 (In reply to lichray from comment #4) > This version breaks bsdconv-opencc. Hmm... There are some api changes from 0.4.3 to 1.x version. The api changes make bsdconv-opencc broken. I will try to fix it and send to upstream later. > building opencc without shared library is surprising IMO. Ok, I removed the option now, please checkout the new patch. (In reply to Iblis Lin from comment #5) Maybe: 1. mark bsdconv-opencc BROKEN, or 2. move the old opencc to something like opencc1. (In reply to lichray from comment #6) Filed an issue to bsdconv-opencc author (& maintainer): https://github.com/buganini/bsdconv-opencc/issues/1 Created attachment 172090 [details]
opencc patch v3
The patch, v3, make `fcitx-rime` PORTREVISION increase to 1.
(note: this patch also applies to chinese/fcitx-rime) fails to build, even with USES=python, see http://people.freebsd.org/~pi/logs/chinese__opencc-103-1467996195.txt (replace 103 with 10i, 93a, cur for other versions). Created attachment 172251 [details]
opencc patch v4
- Add `python:build` to USES
- Also add a post-patch target to change python cmd path.
(This port just needs a `python` symblink, is there any correct way to do this?)
Created attachment 172252 [details]
poudriere testport log on 10.3-RELEASE for patch v4
(In reply to Iblis Lin from comment #11) A more "correct" way to the upstream may be to use cmake find Python, but to us patching is good enough. It fails to build on 9.3a, should this work ? http://people.freebsd.org/~pi/logs/chinese__opencc-93a-1468003806.txt Iblis, thanks for the patches. Please note that confirming the build with Poudriere is sufficient, attaching the build logs is not required (unless explicitly asked for) and only clutters the bugzilla database. ;) (In reply to Kurt Jaeger from comment #14) Need https://www.freebsd.org/doc/en/books/porters-handbook/uses-compiler.html Not sure whether C++11 library is needed as well. With compiler:c++11-lib testbuilds are all fine. Committed, thanks! A commit references this bug: Author: pi Date: Sat Jul 9 03:43:15 UTC 2016 New revision: 418255 URL: https://svnweb.freebsd.org/changeset/ports/418255 Log: chinese/opencc: 0.4.3 -> 1.0.4 PR: 210763 Changes: https://github.com/BYVoid/OpenCC/blob/master/NEWS.md Submitted by: Iblis Lin <iblis@hs.ntnu.edu.tw> Approved by: lichray@gmail.com (maintainer) Changes: head/chinese/opencc/Makefile head/chinese/opencc/distinfo head/chinese/opencc/files/patch-CMakeLists.txt head/chinese/opencc/files/patch-doc_CMakeLists.txt head/chinese/opencc/files/patch-src_tools_CMakeLists.txt head/chinese/opencc/files/patch-src_utils.c head/chinese/opencc/pkg-plist |
Created attachment 172043 [details] opencc patch