Bug 210938
| Summary: | devel/gmake: make-4.2.1/glob/glob.c could use 4 (char*) casts, one per example realloc that is currently given char** first arguments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mark Millard <marklmi26-fbsd> | ||||
| Component: | Individual Port(s) | Assignee: | Tijl Coosemans <tijl> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | w.schwarzenfeld | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(tijl) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
The build was of gmake-4.2.1_1 --which is still in place as of /usr/ports/ -r419343 . Maintainer feedback? Created attachment 189795 [details]
patch
Because this isn't important and because changes to this port require an exp-run I'll include this patch in the next bigger update.
Ok, thanks for reply. A commit references this bug: Author: tijl Date: Tue Feb 20 09:39:15 UTC 2018 New revision: 462385 URL: https://svnweb.freebsd.org/changeset/ports/462385 Log: - Remove fmake hack because FreeBSD 9 is EoL. - Fix compiler warning about realloc. [1] - Remove dependency on gettext-tools and iconv. [2] - Add upstream patch to fix hangs when doing parallel builds. [3] PR: 210938 [1], 212157 [2], 225899 [3] Obtained from: https://git.savannah.gnu.org/cgit/make.git/commit/?id=b552b05251980f693c729e251f93f5225b400714 [3] Exp-run by: antoine, truckman Changes: head/devel/gmake/Makefile head/devel/gmake/files/patch-glob-glob.c head/devel/gmake/files/patch-posixos.c |
Just to get rid of misleading compiler warnings I recommend explicit (char*) casts be added to avoid: glob.c:818:27: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~~~~~~~~~~~~~ * glob.c:937:24: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~~~~~~~~~~~~~ * glob.c:992:39: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] new_pathv = (char **) realloc (pglob->gl_pathv, ^~~~~~~~~~~~~~~ * glob.c:1383:23: warning: incompatible pointer types passing 'char **' to parameter of type 'char *'; dereference with * [-Wincompatible-pointer-types] = (char **) realloc (pglob->gl_pathv, ^~~~~~~~~~~~~~~ * So, for example, = (char **) realloc ((char*) pglob->gl_pathv, The compiler's suggested change is definitely wrong here and could be confusing.