Bug 210960

Summary: [PATCH] bsd.emacs.mk: Remove ${PORTSDIR} from the BUILD/RUN_DEPENDS entries
Product: Ports & Packages Reporter: Raphael Kubo da Costa <rakuco>
Component: Individual Port(s)Assignee: Ashish SHUKLA <ashish>
Status: Closed FIXED    
Severity: Affects Only Me CC: ashish
Priority: --- Keywords: patch
Version: LatestFlags: ashish: maintainer-feedback+
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch v1 rakuco: maintainer-approval+

Description Raphael Kubo da Costa freebsd_committer 2016-07-10 11:02:43 UTC
Created attachment 172310 [details]
Patch v1

At the moment, ports with USE_EMACS=yes fail `make check-sanity' when DEVELOPER=1:

    It looks like the /usr/local/bin/emacs-25.0.93:/usr/ports/editors/emacs-devel depends line has an absolute port origin, make sure to remove ${PORTSDIR}/ from it.

This happens because EMACS_PORTSDIR still has ${PORTSDIR}, so BUILD/RUN_DEPENDS ends up looking like
    RUN_DEPENDS+=  ${EMACS_CMD}:${PORTSDIR}/editors/emacs

The attached patch removes ${PORTSDIR} from EMACS_PORTSDIR and renames the variable to EMACS_PORTDIR since it better reflects what it represents now.
Comment 1 commit-hook freebsd_committer 2016-07-22 03:30:09 UTC
A commit references this bug:

Author: ashish
Date: Fri Jul 22 03:29:47 UTC 2016
New revision: 418909
URL: https://svnweb.freebsd.org/changeset/ports/418909

Log:
  - Update EMACS_PORTSDIR to match new convention of specifying dependency
    ports, and rename it to EMACS_PORTDIR

  PR:		210960
  Submitted by:	rakuco

Changes:
  head/Mk/bsd.emacs.mk
Comment 2 Ashish SHUKLA freebsd_committer 2016-07-22 03:31:04 UTC
Thank you for your diff. I have committed it.