Bug 211004
| Summary: | [PATCH] lang/mono: update from 4.2.3.4 to 4.4.1.0 | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Sergey Brunov <sergey.v.brunov> | ||||||||||
| Component: | Individual Port(s) | Assignee: | freebsd-mono (Nobody) <mono> | ||||||||||
| Status: | Closed Overcome By Events | ||||||||||||
| Severity: | Affects Many People | CC: | cs, dpetrov67, romain | ||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(mono) |
||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Bug Depends on: | 211198, 211371 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
Hi, Unfortunately, devel/newtonsoft-json does not build with Mono 4.4. This is currently blocking the update of lang/mono. (a few other ports needed adjustments too, but workarounds have been found). (In reply to Romain Tartière from comment #1) Hello, Romain! Could you please create the appropriate defect (bug) and specify the dependency on it as «blocking»? Best regards, Sergey Brunov. *** Bug 211371 has been marked as a duplicate of this bug. *** (In reply to sergey.v.brunov from comment #0) Hmmm. When I try this patch in a clean Poudriere jail, I get this result: ===> Patching for mono-4.4.1.0 ===> Applying FreeBSD patches for mono-4.4.1.0 I can't seem to find a patch in there anywhere. => Patch patch-eglib-src-gunicode.c failed to apply cleanly. *** Error code 1 Stop. make: stopped in /usr/ports/lang/mono I'll attach the build log. Created attachment 173017 [details]
Poudriere build log 10.3-RELEASE-p5
Created attachment 173022 [details]
The patch (corrected).
(In reply to Carsten Larsen from comment #4) Hello, Carsten! Thank you very much for the feedback! Sorry for inconvenience. The patch has been corrected. Best regards, Sergey Brunov. (In reply to sergey.v.brunov from comment #7) Hi Sergey With the new patch mono builds in clean jail: 10.3-STABLE FreeBSD 10.3-STABLE r303325 i386, port revision: 419151 Will do more testing with this specific configuration. Sorry. Wrong report. Does still not build. (In reply to Carsten Larsen from comment #9) Hello, Carsten! Could you please point out the errors? Best regards, Sergey Brunov. (In reply to sergey.v.brunov from comment #10) Hi Sergey Same error as before. Remember to check the files in PATCHDIR are applied correctly. They are still there: https://github.com/freebsd/freebsd-ports/tree/master/lang/mono/files (In reply to Carsten Larsen from comment #11) Hello, Carsten! According to the documentation added and removed files — special case (https://www.freebsd.org/doc/en/books/porters-handbook/port-upgrading.html): «Please mention any added or deleted files in the message, as they have to be explicitly specified to svn(1) when doing a commit.» So, please apply the original patch (first version) and remove the «files/patch-eglib-src-gunicode.c» file manually (SVN and file system). Best regards, Sergey Brunov. (In reply to Carsten Larsen from comment #11) Hello, Carsten! Did you succeed with the compilation? Best regards, Sergey Brunov. (In reply to Sergey Brunov from comment #13) Hi Sergey Sorry. Didn't have time yet. I'll take a careful look as soon as I can. Kind regards Carsten Larsen (In reply to Sergey Brunov from comment #13) Hi Sergey. Building now. Should be ready within 24 hours. Created attachment 173381 [details] Reduced build log (In reply to Sergey Brunov from comment #0) Poudriere: No errors (10.3-STABLE r303325, i386) Tested patch from attachment 172375 [details] with deleted files/patch-eglib-src-gunicode.c Portlint: No errors. WARN: Makefile: Consider adding support for a NLS knob to conditionally disable gettext support. WARN: Makefile: Consider defining LICENSE. WARN: /usr/local/poudriere/ports/subversive2/lang/mono/pkg-message: possible use of absolute pathname "/proc". 0 fatal errors and 3 warnings found. (In reply to Sergey Brunov from comment #13) Tested the patch on 10 stable and all seems fine. Kind regards Carsten Larsen 4.4.2.11 is now in the tree. |
Created attachment 172375 [details] The patch. Hello! The patch is attached. Best regards, Sergey Brunov.