Summary: | net/p5-WebService-Dropbox and net/dropbox-api-command: Update to 2.05 and 2.03 respectively | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Ben Woods <woodsb02> | ||||||||
Component: | Individual Port(s) | Assignee: | Ben Woods <woodsb02> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Only Me | CC: | adamw, changlp | ||||||||
Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(changlp) |
||||||||
Version: | Latest | ||||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
URL: | https://reviews.freebsd.org/D7377 | ||||||||||
Attachments: |
|
Description
Ben Woods
2016-07-11 19:00:41 UTC
Created attachment 172389 [details]
Patch to update net/p5-WebService-Dropbox and net/dropbox-api-command
Created attachment 172427 [details]
Patch to update net/p5-WebService-Dropbox and net/dropbox-api-command
Updated patch to tidy up a bit further and update net/dropbox-api-command to 2.05.
Note: in my runtime testing of this I am seeing some errors, so it is not ready to commit yet. I have contacted the author and will update the patch based on feedback.
In the meantime, Lung-Pin please let me know what you think of this patch, and if you would like me to take maintainership or not. Thanks :)
Created attachment 172640 [details]
Patch to update net/p5-WebService-Dropbox and net/dropbox-api-command
This is an updated patch to fix issues with syncing by updating to dropbox-api-command 2.09 (after discussions with the upstream developer to fix the issues). It is all working now, and ready for commit.
Any comments Lung-Pin?
Thanks, Ben
Lung-Pin: Any comments? Are you happy for me to take maintainership of these ports? A commit references this bug: Author: woodsb02 Date: Wed Aug 3 15:31:17 UTC 2016 New revision: 419531 URL: https://svnweb.freebsd.org/changeset/ports/419531 Log: net/p5-WebService-Dropbox: Update to 2.05 net/dropbox-api-command: Update to 2.09 This update brings support for Dropbox APIv2. This is required since, according to dropbox, the API v1 will be disabled on 28th June 2017: https://blogs.dropbox.com/developers/2016/06/api-v1-deprecated/ Convert LWP option (off by default) to FURL option (on by default) as testing has revealed that without the p5-LWP-Protocol-https pkg installed, the following error is given even if the FURL option in enabled. $ dropbox-api sync dropbox:/ ~/Dropbox 2016-07-31T14:09:57 [WebService::Dropbox] [ERROR] https://api.dropboxapi.com/2/files/list_folder {"path":"","recursive":true} -> [501] LWP will support https URLs if the LWP::Protocol::https module is installed. LWP will support https URLs if the LWP::Protocol::https module is installed. PR: 211016 Reviewed by: mat (mentor) Approved by: Lung-Pin Chang <changlp@cs.nctu.edu.tw> (maintainer timeout), adamw (mentor) Differential Revision: https://reviews.freebsd.org/D7377 Changes: head/net/dropbox-api-command/Makefile head/net/dropbox-api-command/distinfo head/net/dropbox-api-command/pkg-descr head/net/dropbox-api-command/pkg-plist head/net/p5-WebService-Dropbox/Makefile head/net/p5-WebService-Dropbox/distinfo head/net/p5-WebService-Dropbox/pkg-descr head/net/p5-WebService-Dropbox/pkg-plist Committed, thanks :) |