Bug 211288
| Summary: | audio/cmus: Update to 2.7.1, Use OPTIONS helpers, Install completion files | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||||
| Status: | Closed FIXED | ||||||||||||||||
| Severity: | Affects Only Me | CC: | herbert, pi | ||||||||||||||
| Priority: | --- | Keywords: | patch | ||||||||||||||
| Version: | Latest | Flags: | pi:
maintainer-feedback-
pi: merge-quarterly- |
||||||||||||||
| Hardware: | Any | ||||||||||||||||
| OS: | Any | ||||||||||||||||
| URL: | https://github.com/cmus/cmus/releases | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Thanks Tobias If you can, please separate the proposed changes into two patches, one for the changes/fixes, the other for the version update so the former can be merged to the quarterly branch and users Created attachment 172991 [details] cmus-quarterly.diff (In reply to Kubilay Kocak from comment #1) Here is a patch against the quarterly branch which adds options helpers and installs the zsh completion file (there is no bash completion file in cmus 2.6.0). Tested in Poudriere FreeBSD 10.3/amd64 twice (once with default options, once with all options enabled). Passes portlint. Created attachment 173055 [details] cmus.diff Regen cmus.diff after ports r419133 so it can be applied again. Created attachment 173230 [details]
cmus.diff
Small update to add an SNDIO option now that audio/sndio is committed.
Created attachment 173232 [details]
cmus.diff
Forgot to svn add a patch.
Created attachment 173722 [details]
cmus.diff
Update to include a patch (already sent to and committed upstream) to fix playing 24/32-bit encoded files with sndio.
testbuilds are OK, thanks! A commit references this bug: Author: pi Date: Fri Aug 26 08:02:06 UTC 2016 New revision: 420903 URL: https://svnweb.freebsd.org/changeset/ports/420903 Log: audio/cmus: 2.6.0 -> 2.7.1 - change to option helpers - installs bash and zsh completion files - now plays 24/32-bit encoded files with sndio PR: 211288 Submitted by: t@tobik.me Approved by: h.skuhra@gmail.com (maintainer timeout) Changes: head/audio/cmus/Makefile head/audio/cmus/distinfo head/audio/cmus/files/patch-Makefile head/audio/cmus/files/patch-configure head/audio/cmus/files/patch-mp4.c head/audio/cmus/files/patch-scripts_checks.sh head/audio/cmus/files/patch-sndio.c head/audio/cmus/pkg-descr head/audio/cmus/pkg-plist The MFH changes the port for OPTIONS etc, but no functional changes, so does it really need MFH ? Would it be policy-OK to MFH ? MFH is not high on the priority with a new quarterly coming up. |
Created attachment 172827 [details] cmus.diff Besides updating cmus to 2.7.1 the attached patch also simplifies port options using option helpers, and installs cmus' bash and zsh completion files. See URL for changes since 2.6.0. I'd also like to take maintainership if that is ok. The port builds fine in a FreeBSD 9.3/i386 Poudriere jail and also passes portlint.