Bug 211375
| Summary: | devel/extra-cmake-modules: Added TEST option, fixed dependencies + update to 5.25.0 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Yuri Victorovich <yuri> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Only Me | CC: | pi, yuri | ||||||||||||
| Priority: | --- | Flags: | koobs:
maintainer-feedback+
pi: merge-quarterly- |
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Created attachment 172985 [details]
patch
* Added HELP option to build the QtHelp file.
Passes poudriere 10.3 amd64.
+ PATHS
+ ${CMAKE_INSTALL_PREFIX}/lib/qt5/bin
doesn't seem correct. You should search in ${LOCALBASE}, not ${PREFIX}. May probably use $ENV{LOCALBASE} while adding LOCALBASE into CONFIGURE_ENV
I think this is a bug in the upstream .cmake, because how come everything else is normally found but not this executable. Will see what can be done. Will need to add the custom executable search path, will do that. Created attachment 173057 [details]
patch
Created attachment 173058 [details]
patch
Thanks Yuri. Note: please set ? flags to + when providing feedback, instead of cancelling them (the prior state is lost otherwise) Ok Kubilay. Created attachment 173628 [details]
patch
Also updates to 5.25.0
Passes poudriere 10.3 amd64 testbuilds are OK, give or take a few binutils hickups... A commit references this bug: Author: pi Date: Wed Aug 31 19:30:52 UTC 2016 New revision: 421185 URL: https://svnweb.freebsd.org/changeset/ports/421185 Log: devel/extra-cmake-modules: 5.24.0 -> 5.25.0 - Add TEST port option to match BUILD_TESTING cmake option o CAVEAT: TEST=off is currently broken, see upstream bug# in Makefile - DOCS requires qcollectiongenerator, added it via QT5=help - TEST requires QT5=buildtools_build,linguisttools_build,qmake_build - Patches FindQCollectionGenerator cmake test for the correct binary path under qt5/ PR: 211375 MFH: 2016Q3 Submitted by: Yuri Victorovich <yuri@rawbw.com> (maintainer) Changes: head/devel/extra-cmake-modules/Makefile head/devel/extra-cmake-modules/distinfo head/devel/extra-cmake-modules/pkg-plist If maintainer does not say otherwise, we'll not MFH, as it would include other changes since 5.22.0. Okay. |
Created attachment 172984 [details] patch This patch: * Adds TEST port option to match BUILD_TESTING cmake option - CAVEAT: TEST=off is currently broken, see upstream bug# in Makefile * DOCS requires qcollectiongenerator, added it via QT5=help * TEST requires QT5=buildtools_build,linguisttools_build,qmake_build * Patches FindQCollectionGenerator cmake test for the correct binary path under qt5/ Passes poudriere on 10.3 amd64