Bug 211386
| Summary: | Kernel build fails when TCP_RFC7413 option set | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | iron.udjin | ||||||
| Component: | kern | Assignee: | Mike Karels <karels> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Some People | CC: | gnn, koobs, ngie, pluknet, re, vangyzen | ||||||
| Priority: | Normal | Keywords: | easy, needs-qa, patch, regression | ||||||
| Version: | 11.0-STABLE | Flags: | koobs:
mfc-stable11+
koobs: mfc-stable10? |
||||||
| Hardware: | amd64 | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Please include your KERNCONF. Created attachment 173029 [details]
BT kernel config
This is a probable fallout from r297225, which is confirmed by that TCP_RFC7413 is successfully built on stable/10 that doesn't have net/route.h in netinet/in_pcb.h. You can try to workaround it with <sys/socket.h> inclusion from tcp_fastopen.c (In reply to Sergey Kandaurov from comment #3) Thank you for workaround. I just tested it and it works fine. Here is patch: --- sys/netinet/tcp_fastopen.c.orig 2016-08-04 15:04:22.000000000 -0600 +++ sys/netinet/tcp_fastopen.c 2016-08-04 15:03:57.000000000 -0600 @@ -111,6 +111,7 @@ #include <sys/socketvar.h> #include <sys/sysctl.h> #include <sys/systm.h> +#include <sys/socket.h> #include <crypto/siphash/siphash.h> Who is going to commit the patch? The original commit was 4 months ago, so I'm assuming this needs to be fixed in the 11.0 branches pending release (cc re@). Note sure if it was ever MFC's, but set mfc-stable10 in case it was. Assign original committer of r297225 for resolution or re-assignment Can someone include the proposed patch as an attachment please Created attachment 173472 [details] bug211386_tcp_fastopen.c.patch Fixed by r303978. https://svnweb.freebsd.org/changeset/base/303978 Assign to committer resolving. Pending MFC's Marking as closed, hope that is right; fixes are on 12-CURRENT, 11-stable, and release/11.0. @Mike If stable/10 is affected it should be MFC'd there (set mfc-stable10 flag to + when committed), unless it cannot be due to $reasons (set mfc-stable10 flag to - with comment) I've just set mfc-stable11 flag to + (as its been merged there). If you could also add a comment with links (svnweb) to the MFC (merge) commits that would be great, as "PR: XXXXX" references were not included in the commit messages, which would have automatically added them here. |
Hello, I'm trying to build kernel 11-STABLE r303338 and it failes to build wnen I have in config file: options TCP_RFC7413 Here is build log: cc -target x86_64-unknown-freebsd11.0 --sysroot=/usr/obj/usr/src/tmp -B/usr/obj/usr/src/tmp/usr/bin -c -O3 -pipe -march=native -fno-strict-aliasing -march=native -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/libfdt -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -MD -MF.depend.tcp_fastopen.o -MTtcp_fastopen.o -mcmodel=kernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wno-error-tautological-compare -Wno-error-empty-body -Wno-error-parentheses-equality -Wno-error-unused-function -Wno-error-pointer-sign -Wno-error-shift-negative-value -mno-aes -mno-avx -std=iso9899:1999 -Werror /usr/src/sys/netinet/tcp_fastopen.c In file included from /usr/src/sys/netinet/tcp_fastopen.c:120: In file included from /usr/src/sys/netinet/in_pcb.h:45: /usr/src/sys/net/route.h:63:18: error: field has incomplete type 'struct sockaddr' struct sockaddr ro_dst; ^ /usr/src/sys/sys/sockbuf.h:64:8: note: forward declaration of 'struct sockaddr' struct sockaddr; ^ 1 error generated. *** Error code 1 Stop. bmake[2]: stopped in /usr/obj/usr/src/sys/BT *** Error code 1 Stop. bmake[1]: stopped in /usr/src *** Error code 1 Stop. make: stopped in /usr/src