Bug 211391

Summary: x11-themes/qtcurve-gtk2: NULL pointer dereference causes applications to crash
Product: Ports & Packages Reporter: Florian Degner <f.degner>
Component: Individual Port(s)Assignee: Jason E. Hale <jhale>
Status: Closed FIXED    
Severity: Affects Only Me CC: jhale
Priority: --- Flags: bugzilla: maintainer-feedback? (makc)
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Fix NULL pointer dereference in gtkDrawFlatBox() none

Description Florian Degner 2016-07-26 18:15:53 UTC 
Created attachment 173014 [details]
Fix NULL pointer dereference in gtkDrawFlatBox()

qtcurve-gtk2 does not rigorously check for the gtk_paint_flat_box() [0] parameter "detail" being NULL. This causes certain applications to segfault. [1]

The attached patch fixes the problem.


[0] https://developer.gnome.org/gtk2/stable/GtkStyle.html#gtk-paint-flat-box
[1] https://bugs.kde.org/show_bug.cgi?id=343704
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-10-22 23:20:40 UTC 
A commit references this bug:

Author: jhale
Date: Sat Oct 22 23:20:21 UTC 2016
New revision: 424491
URL: https://svnweb.freebsd.org/changeset/ports/424491

Log:
  - Fix NULL pointer dereference in gtkDrawFlatBox() in x11-themes/qtcurve-gtk2 [1]
  - Set LICENSE
  - Take maintainership of the qtcurve ports

  PR:		211391 [1]
  Submitted by:	<f.degner@gmx.de> [1]

Changes:
  head/x11-themes/qtcurve/Makefile
  head/x11-themes/qtcurve/files/patch-gtk2_style_qtcurve.c
  head/x11-themes/qtcurve-gtk2/Makefile
Comment 2 Jason E. Hale freebsd_committer freebsd_triage 2016-10-22 23:35:28 UTC 
Fixed, thanks!