Bug 211426
| Summary: | net/gogoc improvements | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | clive | ||||
| Component: | Individual Port(s) | Assignee: | Bartek Rutkowski <robak> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | kami, robak | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(kami) |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: robak Date: Thu Mar 23 12:54:47 UTC 2017 New revision: 436769 URL: https://svnweb.freebsd.org/changeset/ports/436769 Log: net/gogoc: new patch with various improvements - When shutdown, the correct behavior is to send SIGHUP. - New patch patch-icmp_echo_engine.c: When PID of the gogoc process greater than 65536, it can not perform timeout ping check correctly, due to echo_id in icmp_hdr is declared as uint16_t. - New patch patch-freebsd.sh: To mute dmesg noise "nd6_dad_timer: cancel DAD on tun0 because of ND6_IFF_IFDISABLED." - Don't overwrite gogoc.conf on install. PR: 211426 Submitted by: Clive Lin <clive@tongi.org> Approved by: maintainer timeout (8 months) Changes: head/net/gogoc/Makefile head/net/gogoc/files/gogoc.in head/net/gogoc/files/patch-freebsd.sh head/net/gogoc/files/patch-icmp_echo_engine.c head/net/gogoc/pkg-plist Committed, thanks! |
Created attachment 173075 [details] patch 1. When shutdown, the correct behavior is to send SIGHUP. 2. New patch patch-icmp_echo_engine.c: When PID of the gogoc process greater than 65536, it can not perform timeout ping check correctly, due to echo_id in icmp_hdr is declared as uint16_t. There should be a better way to deal with it, but since the upstream is closed, so I think for now a workaround in ports should be just fine. 3. New patch patch-freebsd.sh: To mute dmesg noise "nd6_dad_timer: cancel DAD on tun0 because of ND6_IFF_IFDISABLED." 4. Leave modified gogoc.conf on uninstall. Don't overwrite gogoc.conf on install.