Bug 211444
| Summary: | math/ocamlgsl: Update to 1.19.1 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Rainer Hurling <rhurlin> | ||||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | michipili, pi, rhurlin | ||||||
| Priority: | --- | Flags: | pi:
maintainer-feedback-
|
||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 210168 | ||||||||
| Attachments: |
|
||||||||
|
Description
Rainer Hurling
2016-07-29 19:40:31 UTC
Hi Rainer,
thank you for your patch! I (maintainer) am currently on holiday break
and will not be able to test it. But reviewing it raised the following
point, which relates to the warning you mention:
> 'portlint -AC' complains about DOCSDIR in pkg-plist. This is like in version 1.15.1, also contructed by 'make makeplist' ...
Look at the documentation files in pkg-plist. In the old version, they are
prefixed with %%PORTDOCS%% but not in your new version. Fixing this should
remove the warning generated by portlint.
Side question: what are your concerns about using GitHub as a source?
It is “just as bad” as bitbucket. :)
@committer : Reviewing the patch raised a minor issue in the change,
being on holiday break I cannot test for 2 weeks… If you cannot test,
maybe Rainer could add poudriere logs to the ticket and you could skim
on it? But if waiting is also an option, I'll take care of the details
when I'm back.
Best,
Michael
Created attachment 173113 [details]
revised patch to update math/ocamlgsl
Hi Michael,
thank you for breaking the break and having a look into the PR ;)
%%PORTDOCS%% indeed is necessary, to respect enabled/disabled option DOCS.
%%DOCSDIR%% is the one, portlint complains about, and which should be used to have a changeable path to the docs. With the dilemma of divergent PORTNAME and DISTNAME, I tried a somewhat ugly hack and redefined DOCSDIR within Makefile. At least this builds and installs fine, with and without option DOCS enabled.
I had to use GitHub, because the old repository has been deleted. Probably someone will find a more elegant way to define the GitHub source.
The newer patch handles DOCSDIR and PORTSDIR in Makefile and pkg-plist in a better way, so that 'portlint -AC' does not complain any more.
testbuilds are fine A commit references this bug: Author: pi Date: Fri Oct 21 14:35:12 UTC 2016 New revision: 424419 URL: https://svnweb.freebsd.org/changeset/ports/424419 Log: math/ocamlgsl: update 1.15.1 -> 1.19.1 - master site changed from bitbucket to github PR: 211444 Changes: https://github.com/mmottl/gsl-ocaml/blob/master/CHANGES.txt Submitted by: Rainer Hurling <rhurlin@gwdg.de> Approved by: Michael Gruenewald <michipili@gmail.com> (maintainer timeout) Changes: head/math/ocamlgsl/Makefile head/math/ocamlgsl/distinfo head/math/ocamlgsl/files/patch-setup.ml head/math/ocamlgsl/pkg-plist Committed, thanks |