Bug 211624
| Summary: | x11/xdm: Use MIT-MAGIC-COOKIE-1 by default | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||
| Component: | Individual Port(s) | Assignee: | Kurt Jaeger <pi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Many People | CC: | cy, gerrit.kuehn, koobs, olgeni, pi, x11 | ||||
| Priority: | Normal | Keywords: | easy, patch | ||||
| Version: | Latest | Flags: | pi:
maintainer-feedback+
pi: merge-quarterly+ |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 154502, 191296 | ||||||
| Attachments: |
|
||||||
|
Description
Tobias Kortkamp
2016-08-06 11:42:49 UTC
@Tobias, if this issues proposed change fixes bug 191296 and bug 154502, please add those bug ID's to blocks (and remove them from See Also) Thank you for your report, we need more of these default config improvements :) Please make this important change. I intended to write a bug report like this a couple of times, but never managed to actually do it. I had to do the same thing to make mate work with xdm - seems pretty general. Pending maintainer timeout @Tobias can you confirm this passes QA please (In reply to Kubilay Kocak from comment #4) It builds fine in Poudriere@FreeBSD 10.3/am64, but portlint gives some warnings (patches not being generated by `make makepatch` and some plist problems. See http://paste2.org/WysWXAyD). These were pre-existing issues though. A commit references this bug: Author: pi Date: Fri Aug 26 13:57:14 UTC 2016 New revision: 420921 URL: https://svnweb.freebsd.org/changeset/ports/420921 Log: x11/xdm: Use MIT-MAGIC-COOKIE-1 by default - It is more useful that way - pet portlint for the patches PR: 211624 MFH: 2016Q3 Submitted by: Tobias Kortkamp <t@tobik.me> Changes: head/x11/xdm/Makefile head/x11/xdm/files/patch-config-Makefile.in head/x11/xdm/files/patch-config-Xresources.cpp head/x11/xdm/files/patch-config_xdm-config.cpp head/x11/xdm/files/patch-greeter-greet.c head/x11/xdm/files/patch-xdm_session.c Committed, pending MFH A commit references this bug: Author: pi Date: Fri Aug 26 15:32:16 UTC 2016 New revision: 420926 URL: https://svnweb.freebsd.org/changeset/ports/420926 Log: x11/xdm: minimize the patch to config/xdm-config.cpp PR: 211624 MFH: 2016Q3 Reported by: ak Changes: head/x11/xdm/Makefile head/x11/xdm/files/patch-config_xdm-config.cpp A commit references this bug: Author: pi Date: Fri Aug 26 16:19:05 UTC 2016 New revision: 420929 URL: https://svnweb.freebsd.org/changeset/ports/420929 Log: x11/xdm: remove part of files/patch-greeter-greet.c that no longer applies PR: 211624 Reported by: ak Changes: head/x11/xdm/Makefile head/x11/xdm/files/patch-greeter-greet.c The commits broke xdm.
Protocol not supported by server
Protocol not supported by server
xhost: unable to open display ":0"
Protocol not supported by server
xmodmap: unable to open display ':0'
Protocol not supported by server
Can't open display :0
Protocol not supported by server
xrdb: Resource temporarily unavailable
xrdb: Can't open display ':0'
Protocol not supported by server
Error: Can't open display: :0
Protocol not supported by server
xmodmap: unable to open display ':0'
Protocol not supported by server
xrdb: Resource temporarily unavailable
xrdb: Can't open display ':0'
Protocol not supported by server
xmodmap: unable to open display ':0'
Protocol not supported by server
/usr/local/bin/xset: unable to open display ":0"
Protocol not supported by server
/usr/local/bin/xsetroot: unable to open display ':0'
Protocol not supported by server
Error: Can't open display: :0
Protocol not supported by server
Error: Can't open display: :0
Protocol not supported by server
xscreensaver: 16:23:02: Can't open display: :0
xscreensaver: 16:23:02: initial effective uid/gid was root/schubert (0/1000)
xscreensaver: 16:23:02: running as cy/schubert (1000/1000)
xscreensaver: 16:23:02: This is probably because you're logging in as root. You
shouldn't log in as root: you should log in as a normal user,
and then `su' as needed. If you insist on logging in as
root, you will have to turn off X's security features before
xscreensaver will work.
Please read the manual and FAQ for more information:
https://www.jwz.org/xscreensaver/faq.html
https://www.jwz.org/xscreensaver/man.html
Protocol not supported by server
mwm: Could not open display.
(In reply to Cy Schubert from comment #10) Can you isolate which commit caused the issue/regression? It appeared that files/patch-xdm_session.c in r420921 might have been the cause. But that was not the problem. I was performing a buildworld/installworld (-current) at the time I was building the port. Rebuilding the port again after installworld seems to have resolved the problem. A commit references this bug: Author: pi Date: Tue Aug 30 17:55:04 UTC 2016 New revision: 421126 URL: https://svnweb.freebsd.org/changeset/ports/421126 Log: x11/xdm: Use MIT-MAGIC-COOKIE-1 by default MFH: r420921 r420926 r420929 - It is more useful that way - pet portlint for the patches PR: 211624 Submitted by: Tobias Kortkamp <t@tobik.me> Reported by: ak Approved by: ports-secteam (junovitch) Changes: _U branches/2016Q3/ branches/2016Q3/x11/xdm/Makefile branches/2016Q3/x11/xdm/files/patch-config-Makefile.in branches/2016Q3/x11/xdm/files/patch-config-Xresources.cpp branches/2016Q3/x11/xdm/files/patch-config_xdm-config.cpp branches/2016Q3/x11/xdm/files/patch-greeter-greet.c branches/2016Q3/x11/xdm/files/patch-xdm_session.c MFH done. |