Bug 211639
| Summary: | x11/rofi: Update to 1.1.0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Greg Fitzgerald <gregf> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed Feedback Timeout | ||||||
| Severity: | Affects Only Me | CC: | nomoo | ||||
| Priority: | --- | Keywords: | easy, needs-qa, patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(nomoo) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks for the patch. Please confirm the changes pass QA (portlint, poudriere). poudriere passes just fine. [00:30:01] ====>> [01][00:00:00] Starting build of x11/rofi [00:30:36] ====>> [01][00:00:35] Finished build of x11/rofi: Success [00:30:37] ====>> Stopping 8 builders [00:30:38] ====>> Creating pkgng repository Creating repository in /tmp/packages: 100% Packing files for repository: 100% [00:30:39] ====>> Committing packages to repository [00:30:39] ====>> Removing old packages [00:30:39] ====>> Built ports: devel/ccache devel/llvm37 devel/libclc graphics/libglapi graphics/gbm graphics/libGL graphics/libEGL graphics/cairo devel/gobject-introspection print/harfbuzz x11-toolkits/pango x11/rofi [10amd64-local-workstation] [2016-08-13_09h49m32s] [committing:] Queued: 12 Built: 12 Failed: 0 Skipped: 0 Ignored: 0 Tobuild: 0 Time: 00:30:39 portlint is complaining about a fatal error. FATAL: Makefile: extra item "MASTER_SITES " placed in the PORTNAME section. 1 fatal error and 0 warnings found. The placement looks right to me according to the porters handbook. Can someone confirm? Your patch has numerous whitespace issues, that's what also causes portlint error. Note that version 1.2.0 was released not long ago, so the patch could probably be updated to chase it Ping |
Created attachment 173376 [details] rofi.diff Updates x11/rofi to 1.1.0. I removed USE_GH and pulled the release tarball that davedavenport makes for the releases. This differs from the source.tar.gz that github provides by including a working configure script.