Bug 211707
| Summary: | net/asterisk13: Undefined symbol "DTLS_method" with libressl-devel 2.4.2 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | OlivierW <olivierw1+bugzilla-freebsd> | ||||
| Component: | Individual Port(s) | Assignee: | Guido Falsi <madpilot> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | brnrd, madpilot, olivierw1+bugzilla-freebsd | ||||
| Priority: | --- | Keywords: | needs-qa, patch-ready | ||||
| Version: | Latest | Flags: | madpilot:
maintainer-feedback+
madpilot: merge-quarterly? |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain | ||||||
| Attachments: |
|
||||||
|
Description
OlivierW
2016-08-09 19:34:20 UTC
Created attachment 173475 [details]
svn diff for net/asterisk13
Hi Guido,
Please find a working svn diff attached.
These changes are otherwise harmless. Only LibreSSL defines LIBRESSL_VERSION_NUMBER.
Hope you'll add it to your port!
Thanks,
Bernard.
Thanks for reporting the issue and attaching a full patch. I'm going to test it, I have no objection to adding it to the port. I'll also try to push this upstream later, since it really belongs there. A commit references this bug: Author: madpilot Date: Wed Aug 10 07:28:09 UTC 2016 New revision: 419992 URL: https://svnweb.freebsd.org/changeset/ports/419992 Log: Add patch to fix build with libressl. PR: 211707 Submitted by: olivierw1+bugzilla-freebsd@hotmail.com Patch by: brnrd@ Obtained From: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain MFH: 2016Q3 Changes: head/net/asterisk13/files/patch-res-res_rtp_asterisk.c Committed. I'm not going to merge this patch to 2016Q3 since asterisk version 13.9.2 is in that branch and is unaffected. Hello, I just compiled asterisk13 13.11.1 with libressl-devel 2.4.2 and I'm getting again the exact same error. I looked at the commited patch: https://svnweb.freebsd.org/ports/head/net/asterisk13/files/patch-res-res_rtp_asterisk.c?revision=419992&view=co and it looks strange compared to the ones from OpenBSD: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain (there's the first line "Index: net/asterisk13/files/patch-res_res__rtp__asterisk.c", there are lines beginning with more "+" then necessary). So, I guess the commited patch is incorrect. For now I've reverted back to asterisk13 13.10.0, I'll try again when it'll be fixed :-) Looks like last time I forgot to recompile 13.10.0 with this patch and was using the version with my own patch from OpenBSD. A commit references this bug: Author: brnrd Date: Fri Sep 9 19:40:51 UTC 2016 New revision: 421633 URL: https://svnweb.freebsd.org/changeset/ports/421633 Log: net/asterisk13: Fix broken patch file - Patch was the svn diff to the tree - Convert to a regular patch file PR: 211707 Changes: head/net/asterisk13/files/patch-res-res_rtp_asterisk.c head/net/asterisk13/files/patch-res_res__rtp__asterisk.c I still had the problem after the new patch. After debugging with brnrd@ he founds I had to edit the Makefile to move "ncurses" after "ssl" in USES.
So, now I have in my asterisk13's Makefile:
USES= bison cpe gmake iconv libedit localbase ssl \
shebangfix sqlite ncurses
Phone calls now works!
There's a problem with OpenSSL linking when ncurses appears BEFORE ssl in USES related to order of setting rpath. Simple fix is to push ncurses to the end of the USES definition. A commit references this bug: Author: madpilot Date: Sat Sep 10 07:57:58 UTC 2016 New revision: 421673 URL: https://svnweb.freebsd.org/changeset/ports/421673 Log: Push ncurses USES after ssl USES, it has been reported to solve problems when compiling with non base SSL library. PR: 211707 Submitted by: OlivierW <olivierw1+bugzilla-freebsd@hotmail.com> Changes: head/net/asterisk13/Makefile Thanks for reporting the issue. I have committed the USES change. Can this bug be marked as fixed again? BTW I think this will need merging to 2016Q3 together with the update to 13.11.1. Thanks! A commit references this bug: Author: madpilot Date: Sat Sep 10 19:52:12 UTC 2016 New revision: 421733 URL: https://svnweb.freebsd.org/changeset/ports/421733 Log: MFH: r418897 r419992 r420804 r421247 r421297 r421586 r421587 r421633 r421673 r421696 - Update net/asterisk11 to 11.23.0 - Update net/asterisk13 to 13.10.0 Add patch to fix build with libressl. PR: 211707 Submitted by: olivierw1+bugzilla-freebsd@hotmail.com Patch by: brnrd@ Obtained From: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain Fix build on head after r303920. - Update to 13.11.0 - Make using base compiler the dafault on amd64 and i386 - Prevent asterisk build system from unconditionally using -march=native - Add an OPTIMIZED_CFLAGS option, disabled by default, to allow enabling the native flag - While here, convert to option target helpers. Update net/asterisk11 to 11.23.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b Update net/asterisk13 to 13.11.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b 7fda7920-7603-11e6-b362-001999f8d30b net/asterisk13: Fix broken patch file - Patch was the svn diff to the tree - Convert to a regular patch file PR: 211707 Push ncurses USES after ssl USES, it has been reported to solve problems when compiling with non base SSL library. PR: 211707 Submitted by: OlivierW <olivierw1+bugzilla-freebsd@hotmail.com> Update to 13.11.2 Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/net/asterisk11/Makefile branches/2016Q3/net/asterisk11/distinfo branches/2016Q3/net/asterisk11/files/patch-apps_app__queue.c branches/2016Q3/net/asterisk13/Makefile branches/2016Q3/net/asterisk13/distinfo branches/2016Q3/net/asterisk13/files/patch-main__Makefile branches/2016Q3/net/asterisk13/files/patch-main_crypt.c branches/2016Q3/net/asterisk13/files/patch-res_res__rtp__asterisk.c branches/2016Q3/net/asterisk13/pkg-plist A commit references this bug: Author: madpilot Date: Sat Sep 10 19:52:12 UTC 2016 New revision: 421733 URL: https://svnweb.freebsd.org/changeset/ports/421733 Log: MFH: r418897 r419992 r420804 r421247 r421297 r421586 r421587 r421633 r421673 r421696 - Update net/asterisk11 to 11.23.0 - Update net/asterisk13 to 13.10.0 Add patch to fix build with libressl. PR: 211707 Submitted by: olivierw1+bugzilla-freebsd@hotmail.com Patch by: brnrd@ Obtained From: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain Fix build on head after r303920. - Update to 13.11.0 - Make using base compiler the dafault on amd64 and i386 - Prevent asterisk build system from unconditionally using -march=native - Add an OPTIMIZED_CFLAGS option, disabled by default, to allow enabling the native flag - While here, convert to option target helpers. Update net/asterisk11 to 11.23.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b Update net/asterisk13 to 13.11.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b 7fda7920-7603-11e6-b362-001999f8d30b net/asterisk13: Fix broken patch file - Patch was the svn diff to the tree - Convert to a regular patch file PR: 211707 Push ncurses USES after ssl USES, it has been reported to solve problems when compiling with non base SSL library. PR: 211707 Submitted by: OlivierW <olivierw1+bugzilla-freebsd@hotmail.com> Update to 13.11.2 Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/net/asterisk11/Makefile branches/2016Q3/net/asterisk11/distinfo branches/2016Q3/net/asterisk11/files/patch-apps_app__queue.c branches/2016Q3/net/asterisk13/Makefile branches/2016Q3/net/asterisk13/distinfo branches/2016Q3/net/asterisk13/files/patch-main__Makefile branches/2016Q3/net/asterisk13/files/patch-main_crypt.c branches/2016Q3/net/asterisk13/files/patch-res_res__rtp__asterisk.c branches/2016Q3/net/asterisk13/pkg-plist A commit references this bug: Author: madpilot Date: Sat Sep 10 19:52:12 UTC 2016 New revision: 421733 URL: https://svnweb.freebsd.org/changeset/ports/421733 Log: MFH: r418897 r419992 r420804 r421247 r421297 r421586 r421587 r421633 r421673 r421696 - Update net/asterisk11 to 11.23.0 - Update net/asterisk13 to 13.10.0 Add patch to fix build with libressl. PR: 211707 Submitted by: olivierw1+bugzilla-freebsd@hotmail.com Patch by: brnrd@ Obtained From: http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/ports/telephony/asterisk/patches/patch-res_res_rtp_asterisk_c?rev=1.1&content-type=text/plain Fix build on head after r303920. - Update to 13.11.0 - Make using base compiler the dafault on amd64 and i386 - Prevent asterisk build system from unconditionally using -march=native - Add an OPTIMIZED_CFLAGS option, disabled by default, to allow enabling the native flag - While here, convert to option target helpers. Update net/asterisk11 to 11.23.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b Update net/asterisk13 to 13.11.1 Security: 5cb18881-7604-11e6-b362-001999f8d30b 7fda7920-7603-11e6-b362-001999f8d30b net/asterisk13: Fix broken patch file - Patch was the svn diff to the tree - Convert to a regular patch file PR: 211707 Push ncurses USES after ssl USES, it has been reported to solve problems when compiling with non base SSL library. PR: 211707 Submitted by: OlivierW <olivierw1+bugzilla-freebsd@hotmail.com> Update to 13.11.2 Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/net/asterisk11/Makefile branches/2016Q3/net/asterisk11/distinfo branches/2016Q3/net/asterisk11/files/patch-apps_app__queue.c branches/2016Q3/net/asterisk13/Makefile branches/2016Q3/net/asterisk13/distinfo branches/2016Q3/net/asterisk13/files/patch-main__Makefile branches/2016Q3/net/asterisk13/files/patch-main_crypt.c branches/2016Q3/net/asterisk13/files/patch-res_res__rtp__asterisk.c branches/2016Q3/net/asterisk13/pkg-plist |
