Bug 211826

Summary: [patch] skin version bumps in multimedia/mplayer-skins
Product: Ports & Packages Reporter: Andy Mender <andymenderunix>
Component: Individual Port(s)Assignee: Thomas Zander <riggs>
Status: Closed FIXED    
Severity: Affects Many People Keywords: needs-qa, patch
Priority: --- Flags: riggs: maintainer-feedback+
Version: Latest   
Hardware: amd64   
OS: Any   
Description Flags
All diffs none

Description Andy Mender 2016-08-14 07:38:40 UTC
Created attachment 173650 [details]
All diffs

The Clearlooks and Blue-small skins were updated on MPlayer HQ, hence multimedia/mplayer-skins will not build with the ALL option or the options for respective skins. Also, the MASTER_SITES variable was wrong in the Makefile.

Full diff set:
--- Makefile    2016-08-14 09:27:41.266045000 +0200
+++ Makefile.new        2016-08-14 09:13:23.718940000 +0200
@@ -5,7 +5,7 @@
 CATEGORIES=    multimedia
+MASTER_SITES=  http://www.mplayerhq.hu/MPlayer/skins/
 DISTFILES=     # filled in later after options
 DIST_SUBDIR=   mplayer-skins

--- Makefile.skins      2016-08-14 09:27:50.012393000 +0200
+++ Makefile.skins.new  2016-08-14 09:13:23.719037000 +0200
@@ -10,14 +10,14 @@
 BLUECURVE_FILE=                bluecurve-1.3
 BLUEHEART_FILE=                BlueHeart-1.5
 CANARY_FILE=           Canary-1.2
-CLEARLOOKS_FILE=       Clearlooks-1.6
+CLEARLOOKS_FILE=       Clearlooks-1.7
 CORELIAN_FILE=         Corelian-1.2
 CORNERMP_AQUA_FILE=    CornerMP-aqua-1.4
 CORNERMP_FILE=         CornerMP-1.2
 CUBICPLAYER_FILE=      CubicPlayer-1.1
 CYRUS_FILE=            Cyrus-1.2
 DEFAULT_FILE=          Blue-1.10
-DEFAULT_SMALL_FILE=    Blue-small-1.7
+DEFAULT_SMALL_FILE=    Blue-small-1.8
 DISAPPEARER_FILE=      disappearer-1.2
 DIVXPLAYER_FILE=       divxplayer-1.3
 DUSHKU_FILE=           Dushku-1.2
--- distinfo    2016-08-14 09:28:04.020537000 +0200
+++ distinfo.new        2016-08-14 09:13:23.719128000 +0200
@@ -12,8 +12,8 @@
 SIZE (mplayer-skins/BlueHeart-1.5.tar.bz2) = 281051
 SHA256 (mplayer-skins/Canary-1.2.tar.bz2) = cb39f7d6685dfb49ca13e928969f71e5ecfcdd303fa540a46eb9ea9f154b1adf
 SIZE (mplayer-skins/Canary-1.2.tar.bz2) = 104013
-SHA256 (mplayer-skins/Clearlooks-1.6.tar.bz2) = 1ace4cd0ba776bf58e2141d9be9dfb06cbaedad3e389d10de59c5220d287eadf
-SIZE (mplayer-skins/Clearlooks-1.6.tar.bz2) = 39573
+SHA256 (mplayer-skins/Clearlooks-1.7.tar.bz2) = b99784143fd195ee8dde32fe180120636c3a8766bca2ed21c3b947780b571c03
+SIZE (mplayer-skins/Clearlooks-1.7.tar.bz2) = 39579
 SHA256 (mplayer-skins/Corelian-1.2.tar.bz2) = 44b1cd35734f19af06675c7bfe526f24d96bc60935809ac956ab0a79f1312f49
 SIZE (mplayer-skins/Corelian-1.2.tar.bz2) = 284449
 SHA256 (mplayer-skins/CornerMP-aqua-1.4.tar.bz2) = 84b079492547287eee6d9f68cb8f7915bc757cd972af83c7796948fa0a3dab2f
@@ -26,8 +26,8 @@
 SIZE (mplayer-skins/Cyrus-1.2.tar.bz2) = 228461
 SHA256 (mplayer-skins/Blue-1.10.tar.bz2) = 057524753e032df7c0f9aa2c14f867f245559f685964fba4ac54a9a99768f0f5
 SIZE (mplayer-skins/Blue-1.10.tar.bz2) = 222555
-SHA256 (mplayer-skins/Blue-small-1.7.tar.bz2) = f562d216f5bd2bddc03bb9764096c1fa1931a863e9084e0e0fb10f0317aa5c8c
-SIZE (mplayer-skins/Blue-small-1.7.tar.bz2) = 157039
+SHA256 (mplayer-skins/Blue-small-1.8.tar.bz2) = 6f0d5c50675b62078576c08fbb9adbd9b9ebd2ab32569fbca14c8aeda489e7fa
+SIZE (mplayer-skins/Blue-small-1.8.tar.bz2) = 157095
 SHA256 (mplayer-skins/disappearer-1.2.tar.bz2) = d0c3883e4d44892b7bd9e20b63d3c4baf089c42174cdc54ebbcfb69b651a8880
 SIZE (mplayer-skins/disappearer-1.2.tar.bz2) = 55578
 SHA256 (mplayer-skins/divxplayer-1.3.tar.bz2) = 77fdb86abc82ece0330fa41c9923a09c20893d22b585a3787acd2ce7e598fc8a

As this is my first ever Problem Report, please do provide feedback :).
Comment 1 commit-hook freebsd_committer 2016-08-14 14:58:58 UTC
A commit references this bug:

Author: riggs
Date: Sun Aug 14 14:58:10 UTC 2016
New revision: 420188
URL: https://svnweb.freebsd.org/changeset/ports/420188

  Update distfiles, add NO_ARCH, bump PORTREVISION

  - The Blue-small and Clearlooks skins have been updated upstream
  - PORTREVISION bump, since Blue-small is in the default package
  - Port does not contain architecture dependent files -> NO_ARCH= yes

  PR:		211826
  Submitted by:	andymenderunix@gmail.com
  Reviewed by:	riggs

Comment 2 Thomas Zander freebsd_committer 2016-08-14 15:26:35 UTC
Great to see a new face on our bugzilla! Contributions are always welcome!
I have committed your patch with a few modifications, and since you asked for feedback, here are some details / pointers:

0) Attaching the diff to the PR is sufficient, you do not need to copy and paste it into the text field.
0.1) A poudriere build log is always a good thing to attach alongside a patch. Both for you to verify that the patch works and for a committer to double-check if something is missing.

1) The MASTER_SITES var should be ok. MPLAYERHQ is defined in ${PORTSDIR}/Mk/bsd.sites.mk and expands correctly to include the link you used, see:
[riggs] multimedia/mplayer-skins > make -V MASTER_SITES
http://www.mplayerhq.hu/MPlayer/skins/ http://www1.mplayerhq.hu/MPlayer/skins/ http://www2.mplayerhq.hu/MPlayer/skins/ http://www3.mplayerhq.hu/MPlayer/skins/ http://www4.mplayerhq.hu/MPlayer/skins/ http://www5.mplayerhq.hu/MPlayer/skins/ ftp://ftp.mplayerhq.hu/MPlayer/skins/ ftp://ftp1.mplayerhq.hu/MPlayer/skins/ ftp://ftp4.mplayerhq.hu/MPlayer/skins/ ftp://ftp5.mplayerhq.hu/MPlayer/skins/

2) You did not generate the distinfo by using "make makesum", correct? In most cases, this is the easiest (and hence preferred) way to do it.

3) This patch needs to bump PORTREVISION, because Blue-small is used in the default config of this port, i.e. the official package will have changed content after applying the patch.

Thanks again for your submission, we'd love to see more patches coming!