Bug 211833
| Summary: | devel/qca: correct build without SHA-0 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Matthew Rezny <rezny> | ||||
| Component: | Individual Port(s) | Assignee: | Raphael Kubo da Costa <rakuco> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | CC: | kde | ||||
| Priority: | --- | Flags: | rakuco:
maintainer-feedback+
rakuco: merge-quarterly+ |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Thanks; I'm going to commit this. I also submitted the fix upstream: https://git.reviewboard.kde.org/r/128700/ A commit references this bug: Author: rakuco Date: Tue Aug 16 20:36:04 UTC 2016 New revision: 420303 URL: https://svnweb.freebsd.org/changeset/ports/420303 Log: Adjust the SHA0 removal patch. The upstream fix was still returning "sha0" in all_hash_types() even when SHA0 support is not present. The fix has also been submitted upstream. PR: 211833 Submitted by: matthew@reztek.cz MFH: 2016Q3 Changes: head/devel/qca/Makefile head/devel/qca/files/patch-plugins_qca-ossl_qca-ossl.cpp Assign to committer that resolved A commit references this bug: Author: rakuco Date: Mon Aug 22 10:27:01 UTC 2016 New revision: 420596 URL: https://svnweb.freebsd.org/changeset/ports/420596 Log: MFH: r417968 r418048 r420303 devel/qca: Fix building without SSLv3 and SHA-0 - Add 2 patches from upstream project - Fix building when libssl does not have SSLv3 - Fix building when libcrypto does not have SHA-0 - Replace USE_OPENSSL with USES= ssl - Rework files/patch-libressl with `make makepatch` Tested with devel/qca and devel/qca-qt5 PR: 210053 Approved by: Maintainer time-out Obtained from: KDE Differential Revision: D6885 devel/qca: Fix build failure on 9.3 / OpenSSL 0.9.7 - Re-add patch for compression to satisfy 0.9.7 PR: 210053 Adjust the SHA0 removal patch. The upstream fix was still returning "sha0" in all_hash_types() even when SHA0 support is not present. The fix has also been submitted upstream. PR: 211833 Submitted by: matthew@reztek.cz Approved by: ports-secteam (junovitch) Changes: _U branches/2016Q3/ branches/2016Q3/devel/qca/Makefile branches/2016Q3/devel/qca/files/patch-libressl branches/2016Q3/devel/qca/files/patch-plugins_qca-ossl_CMakeLists.txt branches/2016Q3/devel/qca/files/patch-plugins_qca-ossl_qca-ossl.cpp |
Created attachment 173658 [details] make advertisement of SHA-0 support conditional The patch to build without SHA-0 support neglected to remove sha0 from the list of supported algorithms. The attached patch corrects that oversight.