Bug 211844
| Summary: | [NEW PORT] databases/libzbxpgsql: PostgreSQL monitoring module for zabbix-agent | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Martin Waschbüsch <martin> | ||||||
| Component: | Individual Port(s) | Assignee: | Matthew Seaman <matthew> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | matthew | ||||||
| Priority: | --- | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Passes portlint -AC and poudriere, both on an amd64 10.3 box. There are a number of problems with the port as stands, which would be
picked up by 'poudriere testport' (ie. so poudriere runs the developmer mode QA checks)
* You've got both a pkg-plist file and PLIST_FILES defined, which leads to
duplicated entries in the plist.
* You don't need the @dir entry -- pkg(8) will create any directories it
needs to so it can install all the files in the plist.
* ${NONEXISTENT} in {BUILD,RUN}_DEPENDS is an error.
On the first point, I just deleted pkg-plist and had PLIST_FILES defined like so:
PLIST_FILES= lib/libzbxpgsql.so \
@sample share/examples/libzbxpgsql/template_postgresql_server.xml
Hi (In reply to Matthew Seaman from comment #2) Hi Matthew, thanks for looking this over and your comments - very helpful! While the first two observations make sense to me, the third one does not: In Section 5.8.10 of the Porter's Handbook (https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-depend.html), it says: To depend on another port unconditionally, use the variable ${NONEXISTENT}. So, why do you consider this an error? Thanks a lot for your help! Martin Created attachment 173708 [details]
shar archive of new port
poudriere testport now runs without issues
A commit references this bug: Author: matthew Date: Tue Aug 16 07:57:22 UTC 2016 New revision: 420269 URL: https://svnweb.freebsd.org/changeset/ports/420269 Log: This project provides comprehensive monitoring of PostgreSQL servers using a natively compiled Zabbix agent module, written in C. The module enables discovery and monitoring of tablespaces, databases, namespaces, tables, indexes, etc. A preconfigured Zabbix Template is also included for your convenience. WWW: http://cavaliercoder.com/libzbxpgsql/ PR: 211844 Submitted by: Martin Waschbuesch <martin@waschbuesch.de> Changes: head/databases/Makefile head/databases/libzbxpgsql/ head/databases/libzbxpgsql/Makefile head/databases/libzbxpgsql/distinfo head/databases/libzbxpgsql/files/ head/databases/libzbxpgsql/files/patch-src_libzbxpgsql.c head/databases/libzbxpgsql/pkg-descr head/databases/libzbxpgsql/pkg-message head/databases/libzbxpgsql/pkg-plist A commit references this bug: Author: matthew Date: Tue Aug 16 08:00:53 UTC 2016 New revision: 49286 URL: https://svnweb.freebsd.org/changeset/doc/49286 Log: Add entry for Martin Waschbuesch <martin@waschbuesch.de> PR: 211844 Changes: head/en_US.ISO8859-1/articles/contributors/contrib.additional.xml Committed, thanks! |
Created attachment 173672 [details] shar archive of new port Port of libzbxpgsql providing comprehensive monitoring of PostgreSQL servers using a natively compiled Zabbix agent module, written in C. The module enables discovery and monitoring of tablespaces, databases, namespaces, tables, indexes, etc. A preconfigured Zabbix Template is also included for convenience.