Bug 211862

Summary: www/glpi : request for different default options
Product: Ports & Packages Reporter: dasti <stievenard.david>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Many People CC: marino, mathias
Priority: --- Flags: bugzilla: maintainer-feedback? (mathias)
Version: Latest   
Hardware: Any   
OS: Any   
Bug Depends on: 212222    
Bug Blocks:    

Description dasti 2016-08-15 09:16:24 UTC
Dear port maintainer(s),

I just installed the last version of glpi and it works quite well ;) thanks to you guys !


I suggest that the 2 options

     IMAP=off: IMAP support
     LDAP=off: LDAP protocol support

to be on ny default.

As this is an inventory/ticket software, be able to read mails to generate tickets and use ldap to identify users seems extremely useful by default, what do you think ?

thanks
Dasti
Comment 1 John Marino freebsd_committer freebsd_triage 2016-08-23 02:09:30 UTC
Mathias, 
If you don't like this suggestion, can you indicate rejection in a new comment?

If it's okay, can you approve and perhaps even provide a patch to do it?  (I know it's trivial so I'd consider a patch optional).  But let's give a response one way or another ...
Comment 2 Mathias Monnerville 2016-08-28 13:33:27 UTC
(In reply to John Marino from comment #1)

Sorry for the late answer John. I was away from the Internet...

I think this is a good idea indeed. Will provide a patch ASAP.
Comment 3 Mathias Monnerville 2016-08-28 13:35:38 UTC
(In reply to dasti from comment #0)

Hello Dasti,

sorry for the late answer. I was away from the Internet ...

I think this is a great idea. Will send a patch ASAP.
Comment 4 Mathias Monnerville 2016-08-28 15:10:20 UTC
John, Dasti,

a new GLPI version it out. Those new default options will be part of the patch for the new release.

I'm working on it and will post a link to the related PR here.
Comment 5 Mathias Monnerville 2016-08-28 19:38:31 UTC
Just submitted PR 212222 to upgrade to 0.90.5 and turn on those 2 options by default.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-08-28 20:44:50 UTC
A commit references this bug:

Author: marino
Date: Sun Aug 28 20:44:40 UTC 2016
New revision: 421033
URL: https://svnweb.freebsd.org/changeset/ports/421033

Log:
  www/glpi: Update version 0.90.3 => 0.90.5 and change option defaults

  Per request [1], the IMAP and LDAP options have been set to ON by default.
  The maintainer took the opportunity to upgrade the version [2].
  I converted the options to their modern equivalents and made the
  MASTER_SITES definition more generic to help future upgrades.

  PR:		211862 [1]
  Submitted by:	David Stievenard

  PR:		212222 [2]
  Submitted by:	maintainer

Changes:
  head/www/glpi/Makefile
  head/www/glpi/distinfo
  head/www/glpi/pkg-plist
Comment 7 John Marino freebsd_committer freebsd_triage 2016-08-28 20:45:45 UTC
It's done!