Bug 211881

Summary: sysutils/ipdbtools: Update to 1.1.1
Product: Ports & Packages Reporter: cyclaero
Component: Individual Port(s)Assignee: Kurt Jaeger <pi>
Status: Closed FIXED    
Severity: Affects Only Me CC: cyclaero, pi
Priority: --- Keywords: easy, patch
Version: LatestFlags: cyclaero: maintainer-feedback+
koobs: merge-quarterly-
Hardware: Any   
OS: Any   
See Also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211744
Attachments:
Description Flags
changes from v1.1.0 to v1.1.1 specified in a .diff-file cyclaero: maintainer-approval+

Description cyclaero 2016-08-15 22:03:42 UTC 
Created attachment 173715 [details]
changes from v1.1.0 to v1.1.1 specified in a .diff-file

The initial release of ipdbtools (v1.1.0) did not work on 32bit systems because these lack the __uint128_t integer type which is needed for IPv6 address comparisons and basic arithmetic.

This update includes the necessary uint128 comparison, shift and basic arithmetic operations that provide the missing built-in __uint128_t operations on 32bit systems. The 64bit targets x86-64 and arm64 continue to utilize the built-in operations.

see also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211744#c2 and #c3
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-16 09:42:12 UTC 
Thank you for your submission.

Please:

* Confirm this change passes QA (portlint, poudriere). Information and instructions on testing ports can be found  here:

https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html

Set maintainer-approval to + on attachments for ports you are maintainer of. Attachment -> Details -> maintainer-approval [+]

Committer note: Port does not exist in 2016Q3, MFH not necessary
Comment 2 cyclaero 2016-08-16 09:52:12 UTC 
(In reply to Kubilay Kocak from comment #1)

It does pass portlint.
Comment 3 cyclaero 2016-08-16 10:30:55 UTC 
(In reply to cyclaero from comment #2)

# cd ~/install/port_update/ipdbtools_new
# portlint
looks fine.

In addition it passes all the tests of the porter's manual

1.  make stage
2.  make check-orphans
3.  make package
4.  make install
5.  make deinstall

6.  pkg add work/pkg/ipdbtools-1.1.1.txz
6.1 pkg delete ipdbtools-1.1.1

7.1 make clean
7.2 make
7.3 chown -R rolf work
7.4 sudo -u rolf make package

8.  make distclean
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-08-16 10:42:38 UTC 
@cyclaero Thank you for the timely feedback

All that's left is to set maintainer-approval to + on the attachment

Note: There are other targets to use as well: make check-plist, make stage-qa 

Though poudriere is the recommended/preferred QA tool (See "Tip:" at the bottom of:

https://www.freebsd.org/doc/en/books/porters-handbook/porting-prefix.html
Comment 5 cyclaero 2016-08-16 12:07:27 UTC 
(In reply to Kubilay Kocak from comment #4)

* maintainer-aproval on attachment:

  --> Done

* make stage && make check-plist && make stage-qa && make package

  --> processed to the end without any issues.


* poudriere

  --> forget it, it's not installed here, I dislike already the name
Comment 6 Kurt Jaeger freebsd_committer freebsd_triage 2016-08-16 17:33:58 UTC 
Testbuilds are fine, committed, thanks!
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-08-16 17:34:11 UTC 
A commit references this bug:

Author: pi
Date: Tue Aug 16 17:33:56 UTC 2016
New revision: 420294
URL: https://svnweb.freebsd.org/changeset/ports/420294

Log:
  sysutils/ipdbtools: 1.1.0 -> 1.1.1

  - allows port to build on 32bit/i386

  PR:		211881
  Submitted by:	cyclaero@gmail.com

Changes:
  head/sysutils/ipdbtools/Makefile
  head/sysutils/ipdbtools/distinfo