Summary: | Mk/bsd.port.mk: Fix generic variables in PLIST_SUB_SED regression | ||
---|---|---|---|
Product: | Ports & Packages | Reporter: | Kubilay Kocak <koobs> |
Component: | Ports Framework | Assignee: | Port Management Team <portmgr> |
Status: | Closed FIXED | ||
Severity: | Affects Many People | CC: | mat, ports-bugs |
Priority: | --- | Keywords: | needs-patch, needs-qa, regression |
Version: | Latest | ||
Hardware: | Any | ||
OS: | Any | ||
URL: | https://reviews.freebsd.org/D7580 |
Description
Kubilay Kocak
![]() ![]() I just realised the wrong variable (PLIST_SUB) was used to check the presence of generic variables rather than PLIST_SUB_SED, which was throwing off my tests. Patch (phabricator review) attached fixing two variable references. For lang/python36, the generic variables are no longer present. Custom variables added by the port remain present lang/python36] make -V PLIST_SUB_SED s!3\.6!%%XYDOT%%!g; s!3\.6\.0a4!%%XYZDOT%%!g; s!share/doc/python!%%DOCSDIR%%!g; s!share/examples/python!%%EXAMPLESDIR%%!g; s!share/python!%%DATADIR%%!g; s!www/python!%%WWWDIR%%!g; s!etc/python!%%ETCDIR%%!g; Ah, yes, once again, it's what the lack of review does. A commit references this bug: Author: mat Date: Fri Aug 19 13:09:29 UTC 2016 New revision: 420461 URL: https://svnweb.freebsd.org/changeset/ports/420461 Log: Fixup the PLIST_SUB_SED creation. PR: 211995 Reported by: koobs Sponsored by: Absolight Changes: head/Mk/bsd.port.mk |