Summary: | x11/sterm: update to 0.7 | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Zsolt Udvari <uzsolt> | ||||||
Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Some People | CC: | kitche | ||||||
Priority: | --- | Flags: | amdmi3:
maintainer-feedback+
|
||||||
Version: | Latest | ||||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
Description
Zsolt Udvari
2016-08-22 06:09:28 UTC
Created attachment 173930 [details]
Improved patch
Looks good and builds fine. Suggesting additional minor changes:
- remove unneeded bsd.port.options.mk inclusion
- use options helpers
- Fix WWW according to porter's handbook
Looks good st.info is a bit useless though as you would have to convert it to termcap. Since FREEBSD doesn’t use termifo. But port works. (In reply to kitche from comment #2) If it isn't possible to use st.info I think would skip from install. A commit references this bug: Author: amdmi3 Date: Tue Sep 6 18:17:02 UTC 2016 New revision: 421456 URL: https://svnweb.freebsd.org/changeset/ports/421456 Log: - Update to 0.7 - Regenerate patch - Remove unneeded ncurses dependency - While here, switch to options helpers and fix WWW PR: 212041 Submitted by: udvzsolt@gmail.com Approved by: kitche@kitchetech.com (maintainer) Changes: head/x11/sterm/Makefile head/x11/sterm/distinfo head/x11/sterm/files/patch-Makefile head/x11/sterm/pkg-descr Ok, dropping st.info |