Bug 212126

Summary: x11/temperature.app: noaa URL no longer works
Product: Ports & Packages Reporter: manny
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: patch
Priority: --- Flags: koobs: merge-quarterly?
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
Patch for Temperature.cc
none
Patch for Temperature.h none

Description manny 2016-08-25 02:00:49 UTC 
Created attachment 174039 [details]
Patch for Temperature.cc

1) Sevice was discontinued. See http://www.nws.noaa.gov/om/notification/scn16-16wngccb.htm
2) wget complains on --cache=off: Modified to --no-cache.
3) Had a hard time with a x'0B  character in the Temperature.cc lines 363 and 366. Changed the lines to eliminate the strange character that was causing vi to complain.
Comment 1 manny 2016-08-25 02:02:42 UTC 
Created attachment 174040 [details]
Patch for Temperature.h
Comment 2 Dmitry Marakasov freebsd_committer freebsd_triage 2016-12-26 12:33:19 UTC 
(In reply to manny from comment #0)

> 3) Had a hard time with a x'0B  character in the Temperature.cc lines 363
> and 366. Changed the lines to eliminate the strange character that was
> causing vi to complain.

It's just a degree sign (°), I don't see any problems with it.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-12-26 12:33:31 UTC 
A commit references this bug:

Author: amdmi3
Date: Mon Dec 26 12:33:16 UTC 2016
New revision: 429503
URL: https://svnweb.freebsd.org/changeset/ports/429503

Log:
  - Fix wget argument, --cache=off -> --no-cache
  - Fix execlp call, terminate argument list with NULL instead of 0 (otherwise execve returns EFAULT)
  - Fix data url, as the previous one was discontinued

  PR:		212126
  Submitted by:	manny@computer.org

Changes:
  head/x11/temperature.app/Makefile
  head/x11/temperature.app/files/patch-Temperature.cc
  head/x11/temperature.app/files/patch-Temperature.h