Bug 212154
| Summary: | textproc/source-highlight: Fix problem with bash completion file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Tobias Kortkamp <tobik> | ||||
| Component: | Individual Port(s) | Assignee: | Kevin Lo <kevlo> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | kevlo | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(kevlo) |
||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| URL: | https://forums.freebsd.org/threads/57407/ | ||||||
| Attachments: |
|
||||||
A commit references this bug: Author: kevlo Date: Fri Aug 26 01:02:37 UTC 2016 New revision: 420884 URL: https://svnweb.freebsd.org/changeset/ports/420884 Log: Fix the run dependency and install the bash completion file. PR: 212154 Submitted by: Tobias Kortkamp <t@tobik.me> Changes: head/textproc/source-highlight/Makefile head/textproc/source-highlight/files/patch-configure head/textproc/source-highlight/files/patch-gl_getopt.in.h head/textproc/source-highlight/files/patch-gl_stdbool.in.h head/textproc/source-highlight/files/patch-src-cmdline.c head/textproc/source-highlight/files/patch-stdbool.in.h head/textproc/source-highlight/files/patch-tests_Makefile.in head/textproc/source-highlight/pkg-plist Committed, thanks. |
Created attachment 174068 [details] source-highlight.diff The run dependency for BASH declares a dependency on ${LOCALBASE}/etc/bash_completion which is never installed by shells/bash-completion, so the build will fail when BASH=on. Also see the linked forum thread. We could fix the run dependency, or remove the BASH option all together and always install the bash completion file. It's not a generated file and is very small. IMHO it's not worth having the option in the first place, so I removed it. I've also cleaned up other things in the port, so that portlint is happy with the port again. portlint ok, poudriere testport FreeBSD 10.2/amd64 ok