Bug 212230

Summary: security/pecl-scrypt: Update to 1.4.2, Take MAINTAINER'ship
Product: Ports & Packages Reporter: Danilo G. Baio <dbaio>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
pecl-scrypt-1.4.2.patch
none
pecl-scrypt-1.4.2_v2.patch none

Description Danilo G. Baio freebsd_committer freebsd_triage 2016-08-29 02:28:34 UTC 
Created attachment 174172 [details]
pecl-scrypt-1.4.2.patch

- Update to 1.4.2
- Add LICENSE_FILE
- Revert PHP 7 support
- Fix PLIST_FILES on TEST option
- Remove compiler stuff (not necessary anymore)
- Take maintainer'ship

Changelog:

1.4.2 - Fixed memory leak in PHP 7 (#48), weak CSPRNG on salts in the example
        file (#44)
1.4.1 - Fixed issue on RHEL 6 in x86_64 with PHP 7 (#46)
1.4   - Added PHP 7 support (#39, #40, #45)
      - Removed support for PHP 5.2 as Travis no longer supports testing it
1.3   - Fixed install pecl install on machines which do not support SSE 
        extensions (#37)
      - Added a segfault catch for when an invalid N was passed in (#31)

https://pecl.php.net/package-changelog.php?package=scrypt

portlint: OK (looks fine.)
testport: 
	poudriere: i386,  10.3 php56/php70 (OK)
	poudriere: amd64, 10.3 php56/php70 (OK)
	poudriere: i386,  9.3  php56/php70 (OK)
	poudriere: amd64, 9.3  php56/php70 (OK)
	poudriere: i386,  12   php56/php70 (OK)
	poudriere: amd64, 12   php56/php70 (OK)
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-29 11:20:18 UTC 
There's no need to install test files. Instead, you could provide do-test: target which runs them. Otherwise looks good to me.
Comment 2 Danilo G. Baio freebsd_committer freebsd_triage 2016-08-29 12:57:20 UTC 
Created attachment 174181 [details]
pecl-scrypt-1.4.2_v2.patch


I prefer remove this option.
How could I test it on powerpc64 ?

Patch updated.

Another around on poudriere testport: 
	poudriere: i386,  10.3 php56/php70 (OK)
	poudriere: amd64, 10.3 php56/php70 (OK)
	poudriere: i386,  9.3  php56/php70 (OK)
	poudriere: amd64, 9.3  php56/php70 (OK)
	poudriere: i386,  12   php56/php70 (OK)
	poudriere: amd64, 12   php56/php70 (OK)

portlint: OK (looks fine.)

Thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-09-09 19:13:26 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Sep  9 19:12:55 UTC 2016
New revision: 421627
URL: https://svnweb.freebsd.org/changeset/ports/421627

Log:
  - Update to 1.4.2
  - Add LICENSE_FILE
  - Bring back PHP 7 support
  - Simplify port
  - Take maintainership

  PR:		212230
  Submitted by:	dbaio@bsd.com.br

Changes:
  head/security/pecl-scrypt/Makefile
  head/security/pecl-scrypt/distinfo