Bug 212240

Summary: www/privoxy: Update to 3.0.26
Product: Ports & Packages Reporter: Fabian Keil <fk>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Some People CC: pawel
Priority: --- Flags: koobs: maintainer-feedback+
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
www/privoxy: Update to 3.0.26 stable
fk: maintainer-approval+
www/privoxy: Update to 3.0.26 stable (fixed plist) fk: maintainer-approval+

Description Fabian Keil 2016-08-29 14:23:09 UTC 
Created attachment 174185 [details]
www/privoxy: Update to 3.0.26 stable

- Use official website as primary master site.
- Add option to increase the number of connections
  Privoxy can serve at the same time.
- Quote variables in the rc script more consistently.

The upstream changes are documented at:
https://www.privoxy.org/3.0.26/user-manual/whatsnew.html
Comment 1 Pawel Pekala freebsd_committer freebsd_triage 2016-08-30 14:08:28 UTC 
There is plist issue:

====> Checking for pkg-plist issues (check-plist)
===> Parsing plist
===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%ETCDIR%%/templates/client-tags
===> Checking for items in pkg-plist which are not in STAGEDIR
===> Error: Plist issues found.
*** Error code 1
Comment 2 Fabian Keil 2016-08-30 14:40:10 UTC 
Created attachment 174215 [details]
www/privoxy: Update to 3.0.26 stable (fixed plist)

Sorry, my mistake.

I tested with "poudriere bulk ..." but apparently did not yet
configure this poudriere system to always run check-plist.

I was able to reproduce the issue with "poudriere testport ..."
and unsurprisingly adding the file to the plist fixes the issue.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-30 20:16:28 UTC 
Can't prestart actions from rc.d file be replaced with plist practices?

E.g. @sample, @owner/@group, @dir etc.
Comment 4 Fabian Keil 2016-08-31 10:17:27 UTC 
In case of config and match-all.action that's probably the case.

Thanks for the suggestion, I'll look into this for the next update.
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-31 12:08:28 UTC 
Thank you!
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-08-31 12:09:01 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Aug 31 12:08:22 UTC 2016
New revision: 421155
URL: https://svnweb.freebsd.org/changeset/ports/421155

Log:
  - Update to 3.0.26
  - Use official website as primary master site.
  - Add option to increase the number of connections Privoxy can serve at the same time
  - Quote variables in the rc script more consistently.

  The upstream changes are documented at:
  https://www.privoxy.org/3.0.26/user-manual/whatsnew.html

  PR:		212240
  Submitted by:	fk@fabiankeil.de (maintainer)

Changes:
  head/www/privoxy/Makefile
  head/www/privoxy/distinfo
  head/www/privoxy/files/privoxy.in
  head/www/privoxy/pkg-plist