Summary: | textproc/libxml2-reference: fix missing LICENSE_FILE | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Carlos J. Puga Medina <cpm> | ||||||
Component: | Individual Port(s) | Assignee: | freebsd-gnome (Nobody) <gnome> | ||||||
Status: | Closed FIXED | ||||||||
Severity: | Affects Many People | CC: | amdmi3, gnome, kwm, marino | ||||||
Priority: | --- | Keywords: | patch, patch-ready | ||||||
Version: | Latest | Flags: | bugzilla:
maintainer-feedback?
(gnome) cpm: merge-quarterly? |
||||||
Hardware: | Any | ||||||||
OS: | Any | ||||||||
Attachments: |
|
John should we remove LICENSE block? That would be the fastest fix. The alternative is to undefine LICENSE. The whole construction is pretty shaky. The use of shell commands (e.g. != evaluations) is highly discouraged. There's got to be better way that can avoid stuff like that. Created attachment 174271 [details]
patch
- Remove LICENSE block
(In reply to John Marino from comment #2) Done! Can you commit this without gnome hat? i guess I can since you are the one that brought in the license. (In reply to John Marino from comment #5) OK, thanks. A commit references this bug: Author: marino Date: Wed Aug 31 20:13:51 UTC 2016 New revision: 421190 URL: https://svnweb.freebsd.org/changeset/ports/421190 Log: textproc/libxml2: remove LICENSE block to unbreak libxml2-reference The addition of the MIT licence block broke at least the textproc/libxml2-reference port due to how the helper script bsd.gnome-reference.mk works. Removed at the request of person that suggested the license be added [2]. PR: 209806 PR: 212265 [2] Reported by: cpm Changes: head/textproc/libxml2/Makefile A commit references this bug: Author: cpm Date: Tue Sep 6 18:28:15 UTC 2016 New revision: 421459 URL: https://svnweb.freebsd.org/changeset/ports/421459 Log: MFH: r421190 textproc/libxml2: remove LICENSE block to unbreak libxml2-reference The addition of the MIT licence block broke at least the textproc/libxml2-reference port due to how the helper script bsd.gnome-reference.mk works. Removed at the request of person that suggested the license be added [2]. PR: 209806 PR: 212265 [2] Reported by: cpm Approved by: ports-secteam (feld) Changes: _U branches/2016Q3/ branches/2016Q3/textproc/libxml2/Makefile |
Created attachment 174222 [details] patch libxml2-reference fails to build with following error: =======================<phase: patch >============================ ===> Missing license file for MIT in /wrkdirs/usr/ports/textproc/libxml2-reference/work/libxml2-2.9.4/COPYING *** [/wrkdirs/usr/ports/textproc/libxml2-reference/work/.license_done.libxml2._usr_local] Error code 1 Stop in /usr/ports/textproc/libxml2-reference. Also it was reported by pkg-fallout. Patch fix missing LICENSE_FILE.