Bug 212395
| Summary: | databases/sqlitebrowser: Update to 3.9.0 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Loïc Bartoletti <lbartoletti> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Ruslan Makhmatkhanov <rm> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Some People | CC: | rm, tcberner | ||||||||||||
| Priority: | --- | Flags: | lbartoletti:
maintainer-feedback+
|
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
Maintainer informed via mail Created attachment 174397 [details]
New port sqlitebrowser-qt5
Created attachment 175015 [details] New diff after sqlitebrowser-qt5 added New diff port since sqlitebrowser-qt5 is committed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211217 Hi * Are you sure, you wanted to replace '%%DATADIR%%' in the patches with its expansion? * INSTALLS_ICONS is not needed, as this is not a gtk+ application. mfg Tobias (In reply to Tobias C. Berner from comment #4) OK. I misunderstand the porlint's warning for INSTALL_ICONS. I remove it. For DATADIR, yes it's patch needed for a correct FreeBSD install. Created attachment 175018 [details]
remove INSTALL_ICONS
Created attachment 175156 [details]
Fix patch (DATADIR) for sqlitebrowser-3.9.0
A commit references this bug: Author: rm Date: Sat Oct 1 01:05:15 UTC 2016 New revision: 423030 URL: https://svnweb.freebsd.org/changeset/ports/423030 Log: databases/sqlitebrowser: update to 3.9.0 - update to 3.9.0 - update maintainer's email - pet portlint PR: 212395 Submitted by: lbartoletti <lbartoletti@tuxfamily.org> (maintainer) Changes: head/databases/sqlitebrowser/Makefile head/databases/sqlitebrowser/distinfo head/databases/sqlitebrowser/files/patch-CMakeLists.txt head/databases/sqlitebrowser/files/patch-src-Application.cpp head/databases/sqlitebrowser/files/patch-src-PreferencesDialog.cpp Committed with couple of changes: 1. USE_QT5 components were not changed, because poudriere build showed no evidence that these dependencies are needed anywhere behind build phase. 2. Port name was trimmed from COMMENT Hmm, I can oath that Assignee field was filled with freebsd-ports-bugs@. Apologies, Tobias. |
Created attachment 174396 [details] Single options port Update to 3.9.0 Add options to use Qt5 or Qt4. For submitter, I have made two patch: - First, using single option for Qt5/Qt5 - Second, creating a port sqlitebrowser-qt5 which conflicts sqlitebrowser (Qt4) I don't know which is the best practice. Portlint OK Poudriere 10, 11, 12 amd64 and i386 OK