Bug 212411
| Summary: | audio/speex: fix build with --disable-silent-rules | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Dmitry Marakasov <amdmi3> | ||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Some People | Keywords: | easy | ||||
| Priority: | --- | Flags: | bugzilla:
maintainer-feedback?
(multimedia) koobs: merge-quarterly? |
||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 212075 | ||||||
| Attachments: |
|
||||||
@Dmitry These appear to be blanket (implicit approval, just fix it if well tested/QA'd) changes. Feel free to assign/commit/mfh A commit references this bug: Author: amdmi3 Date: Fri Sep 9 19:24:33 UTC 2016 New revision: 421630 URL: https://svnweb.freebsd.org/changeset/ports/421630 Log: - Fix build with --disable-silent-rules PR: 212411 Submitted by: amdmi3 Approved by: portmgr Changes: head/audio/speex/files/ head/audio/speex/files/patch-configure |
Created attachment 174414 [details] Patch Exp-run with --disable-silent-rules added to CONFIGURE_ARGS showed failure for audio/speex. It's caused by broken configure script which checks $enableval after checking for corresponding --enable/--disable option, but if option was not set, enableval value left from the previous (unrelated) option is used. As result, $enableval=no set by check in --disable-silent-rules also turns off binaries as if --disable-binaries was given. To fix that, unset $enableval after silent-rules processing.