Bug 212427

Summary:

[PATCH] devel/extra-cmake-modules: Avoid passing -std=c++0x when it is not present

Product:

Ports & Packages

Reporter:

Raphael Kubo da Costa <rakuco>

Component:

Individual Port(s)

Assignee:

freebsd-ports-bugs (Nobody) <ports-bugs>

Status:

Closed FIXED

Severity:

Affects Only Me

CC:

kde, yuri

Priority:

---

Keywords:

patch

Version:

Latest

Flags:

yuri: maintainer-feedback+

Hardware:

Any

OS:

Any

Attachments:

Description	Flags
Proposed patch	rakuco: maintainer-approval+

Description Raphael Kubo da Costa freebsd_committer

2016-09-06 19:34:04 UTC

Created attachment 174433 [details]
Proposed patch

The attached patch extends the check in KDECompilerSettings.cmake to only pass -std=c++0x to the compiler if it's recent enough, otherwise we risk passing that to base GCC and breaking the build of multimedia/qt5-phonon4 on FreeBSD 9: http://beefy2.nyi.freebsd.org/data/93amd64-default/421400/logs/qt5-phonon4-4.9.0.log

Comment 1 commit-hook freebsd_committer

2016-09-06 19:44:23 UTC

A commit references this bug:

Author: rakuco
Date: Tue Sep  6 19:44:06 UTC 2016
New revision: 421463
URL: https://svnweb.freebsd.org/changeset/ports/421463

Log:
  Avoid passing -std=c++0x when it is not supported

  Extend the check in KDECompilerSettings.cmake to only pass -std=c++0x to the
  compiler if it's recent enough, otherwise we risk passing that to base GCC and
  breaking the build of any extra-cmake-modules-dependent port using
  KDECompilerSettings.cmake on FreeBSD 9 (such as multimedia/qt5-phonon4).

  PR:		212427
  Submitted by:	rakuco
  Approved by:	yuri@rawbw.com (maintainer)

Changes:
  head/devel/extra-cmake-modules/Makefile
  head/devel/extra-cmake-modules/files/patch-kde-modules_KDECompilerSettings.cmake

Comment 2 Raphael Kubo da Costa freebsd_committer

2016-09-06 19:44:37 UTC

Thanks!