Summary: | www/firefox: Fix build with libc++ 3.9.0 | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Dimitry Andric <dim> | ||||||||
Component: | Individual Port(s) | Assignee: | freebsd-gecko (Nobody) <gecko> | ||||||||
Status: | Closed FIXED | ||||||||||
Severity: | Affects Some People | CC: | dim, emaste, jbeich | ||||||||
Priority: | --- | Keywords: | patch | ||||||||
Version: | Latest | Flags: | jbeich:
maintainer-feedback+
|
||||||||
Hardware: | Any | ||||||||||
OS: | Any | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 212343 | ||||||||||
Attachments: |
|
Description
Dimitry Andric
2016-09-06 20:51:13 UTC
Created attachment 174440 [details]
Patch for mozilla bug 1269171
Can you confirm Firefox trunk builds fine on projects/clang390-import before r305496? If so I'd prefer to find out what fixed it before using libc++ workaround in base. Maybe you need to add type_traits into config/*-headers like Mozilla bug 1268816 did. 1. pkg install mercurial 2. hg clone https://hg.mozilla.org/mozilla-unified/ firefox 3. hg up central or if you prefer git 1. pkg install git 2. git clone https://github.com/mozilla/gecko-dev/ firefox 4. cd firefox 6. ./mach bootstrap # press 2, y, y, 2 in prompts 7. nice ./mach build 8. ./mach run Created attachment 174469 [details]
Patch for mozilla bug 1268816
Comment on attachment 174439 [details]
Patch for mozilla bug 1245076
Looks fine and builds fine on 9.3R i386 and 10.1R i386.
Comment on attachment 174469 [details] Patch for mozilla bug 1268816 Hand over to dim@ whether to land this one and back out base r305496. (In reply to Jan Beich from comment #5) > Comment on attachment 174469 [details] > Patch for mozilla bug 1268816 > > Hand over to dim@ whether to land this one and back out base r305496. I haven't tried mozilla-central yet, but www/firefox 47.0.1,2 with only patch-bug1268816, and base r305496 reverted, it still dies with: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/mozglue/misc/TimeStamp.cpp:11: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/include/mozilla/TimeStamp.h:13: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/include/mozilla/FloatingPoint.h:15: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/include/mozilla/MathAlgorithms.h:15: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/stl_wrappers/cmath:28: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/system_wrappers/new:3: In file included from /usr/include/c++/v1/new:70: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/system_wrappers/exception:3: In file included from /usr/include/c++/v1/exception:82: In file included from /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/stl_wrappers/type_traits:34: /usr/work/share/dim/ports/www/firefox/work/firefox-47.0.1/obj-i386-portbld-freebsd12.0/dist/include/mozilla/mozalloc.h:184:33: error: no type named 'bad_alloc' in namespace 'std' void* operator new(size_t size) MOZALLOC_THROW_BAD_ALLOC ^~~~~~~~~~~~~~~~~~~~~~~~ So I assume we need all three patches, then? Going to try that next. Comment on attachment 174469 [details] Patch for mozilla bug 1268816 (In reply to Dimitry Andric from comment #6) > So I assume we need all three patches, then? Going to try that next. Okay, so with all three patches in files/, and base r305496 reverted, www/firefox builds to completion. Great! A commit references this bug: Author: dim Date: Wed Sep 7 21:47:23 UTC 2016 New revision: 421523 URL: https://svnweb.freebsd.org/changeset/ports/421523 Log: Make www/firefox build with libc++ 3.9.0, by adding patches for upstream bugs 1245076, 1268816 and, 1269171. Together, these solve a number of problems with Firefox's generated wrapper headers for the C++ standard library. Approved by: jbeich (maintainer) PR: 212431 Changes: head/www/firefox/files/patch-bug1245076 head/www/firefox/files/patch-bug1268816 head/www/firefox/files/patch-bug1269171 Committed. Thanks for the help, Jan! A commit references this bug: Author: jbeich Date: Sun Sep 18 18:38:23 UTC 2016 New revision: 422403 URL: https://svnweb.freebsd.org/changeset/ports/422403 Log: gecko: apply r421523 to the rest Bump PORTREVISION to get a clear regression window. PR: 212431 Changes: head/mail/thunderbird/Makefile head/mail/thunderbird/files/patch-bug1245076 head/mail/thunderbird/files/patch-bug1268816 head/mail/thunderbird/files/patch-bug1269171 head/www/firefox-esr/Makefile head/www/firefox-esr/files/patch-bug1245076 head/www/firefox-esr/files/patch-bug1268816 head/www/firefox-esr/files/patch-bug1269171 head/www/libxul/Makefile head/www/libxul/files/patch-bug1245076 head/www/libxul/files/patch-bug1268816 head/www/libxul/files/patch-bug1269171 head/www/seamonkey/Makefile head/www/seamonkey/files/patch-bug1245076 head/www/seamonkey/files/patch-bug1268816 head/www/seamonkey/files/patch-bug1269171 (In reply to commit-hook from comment #10) > A commit references this bug: > > Author: jbeich > Date: Sun Sep 18 18:38:23 UTC 2016 > New revision: 422403 > URL: https://svnweb.freebsd.org/changeset/ports/422403 > > Log: > gecko: apply r421523 to the rest ... > head/www/libxul/Makefile > head/www/libxul/files/patch-bug1245076 > head/www/libxul/files/patch-bug1268816 > head/www/libxul/files/patch-bug1269171 Ah, I was just about to submit a fix for libxul, but nevermind it now. :) Thanks! |