Bug 212462
| Summary: | lang/spidermonkey185: fails to build on armv6 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Mikael Urankar <mikael> | ||||||
| Component: | Individual Port(s) | Assignee: | Koop Mast <kwm> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | koobs, kwm, linimon, mikael | ||||||
| Priority: | --- | Keywords: | needs-qa, patch | ||||||
| Version: | Latest | Flags: | koobs:
maintainer-feedback+
|
||||||
| Hardware: | arm | ||||||||
| OS: | Any | ||||||||
| URL: | http://beefy8.nyi.freebsd.org/data/head-armv6-default/p421100_s305036/logs/errors/spidermonkey185-1.8.5_2.log | ||||||||
| Attachments: |
|
||||||||
Thank you for the patch Mikael. Did the changes come from an upstream commit/pr/issue? If so, please either include the references in the patches as a comment header, or add them here as a comment so they can be included in the commit. Also, does this fix arm builds on FreeBSD 9.x, 10.x and 11.x or should this be version limited? I do not have arm hardware to test, so confirmation of QA (poudriere, etc) passing on those versions would be greatly appreciated. If you can, please include them as attachments :) The patch is from me. It builds on 11.x, it should build on 10.x and I have no idea for 9.x (anyway we only build packages for -current as of today) The attachments are too big: 2.6MB, bugzilla don't accept them. build log for 11: http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey185-1.8.5_2_freebsd11.log Created attachment 179670 [details] armv6 fix regen after ports r426198 I tested the earlier patch and it worked for me. I will re-test with the new one. I only removed the BROKEN_armv6 line ping Apologies for the delay Mikael
@Mark can you test and confirm QA for attachment 179670 [details] ?
Build logs (too large to attach): http://mikael.urankar.free.fr/FreeBSD/arm/build_logs/spidermonkey185-1.8.5_3.log A commit references this bug: Author: kwm Date: Mon Jun 5 12:36:14 UTC 2017 New revision: 442611 URL: https://svnweb.freebsd.org/changeset/ports/442611 Log: Add patches to fix the build on armv6. PR: 212462 Submitted by: mikael.urankar@gmail.com Approved by: maintainer (koobs@) Changes: head/lang/spidermonkey185/Makefile head/lang/spidermonkey185/files/patch-assembler_jit_ExecutableAllocator.h head/lang/spidermonkey185/files/patch-assembler_wtf_Platform.h head/lang/spidermonkey185/files/patch-configure.in head/lang/spidermonkey185/files/patch-nanojit_CodeAlloc.cpp head/lang/spidermonkey185/files/patch-nanojit_njcpudetect.h Assign to committer that resolved Thanks Koop! |
Created attachment 174481 [details] armv6 patch Hi, The attached patch allows the build to succeed. Thanks in advance.