|Summary:||security/letsencrypt.sh: Update to 0.3.0|
|Product:||Ports & Packages||Reporter:||Sascha Holzleiter <sascha>|
|Component:||Individual Port(s)||Assignee:||Thomas Zander <riggs>|
|Severity:||Affects Only Me||CC:||riggs|
Description Sascha Holzleiter 2016-09-08 12:14:10 UTC
Created attachment 174526 [details] v0.3.0 diff This patch updates letsencrypt.sh to Version 0.3.0 . There have been breaking changes upstream. I added a warning about it to pkg-message but maybe this should also go into UPDATING. The specifics: - The config filename has been changed from "config.sh" to "config" - The WELLKNOWN location has been changed upstream to "/var/www/letsencrypt". I patched that to be "%%PREFIX%%/www/letsencrypt" in accordance to hier(7). Both will require existing users to change their configs.
Comment 1 Sascha Holzleiter 2016-09-08 12:15:28 UTC
Comment 2 Kubilay Kocak 2016-09-08 14:06:29 UTC
Thank you Sascha. QA logs are not longer required as attachments, but are preferred if requested, over remote URL's, so that all information is self-contained in the issue. Unless requested, just mention that QA has passed in your descriptions, like: portlint: OK (looks fine.) testport: OK (poudriere: <versions>, <archs>, <options> tested) Feel free to include an UPDATING entry in the patch as well
Comment 3 Kubilay Kocak 2016-09-08 14:07:58 UTC
Forgot to note: UPDATING entries are preferable to pkg-messages for one-off version -> version updates/instructions and don't need to be removed in future commits like pkg-message messaging
Comment 5 Sascha Holzleiter 2016-09-08 15:52:53 UTC
Created attachment 174532 [details] UPDATING entry
Comment 6 Sascha Holzleiter 2016-09-08 15:54:07 UTC
Thanks for clarifying! I've generated a new diff without the pkg-message warning and added an attachment with an UPDATING entry.
Comment 7 Sascha Holzleiter 2016-09-08 15:56:25 UTC
Created attachment 174533 [details] UPDATING entry Forgot the obligatory "users of" phrase within AFFECTS:
Comment 8 commit-hook 2016-09-10 16:22:07 UTC
A commit references this bug: Author: riggs Date: Sat Sep 10 16:21:53 UTC 2016 New revision: 421708 URL: https://svnweb.freebsd.org/changeset/ports/421708 Log: Update to upstream version 0.3.0 Detailed maintainer log regarding breaking upstream changes: - The config filename has been changed from "config.sh" to "config" - The WELLKNOWN location has been changed upstream to "/var/www/letsencrypt" The port uses "%%PREFIX%%/www/letsencrypt" in accordance to hier(7). PR: 212485 Submitted by: email@example.com (maintainer) Changes: head/security/letsencrypt.sh/Makefile head/security/letsencrypt.sh/distinfo head/security/letsencrypt.sh/files/000.letsencrypt.sh.in head/security/letsencrypt.sh/files/pkg-message.in
Comment 9 commit-hook 2016-09-10 16:32:09 UTC
A commit references this bug: Author: riggs Date: Sat Sep 10 16:31:58 UTC 2016 New revision: 421709 URL: https://svnweb.freebsd.org/changeset/ports/421709 Log: Document breaking upstream changes in security/letsencrypt.sh PR: 212485 Submitted by: firstname.lastname@example.org (maintainer security/letsencrypt.sh) Reviewed by: riggs Changes: head/UPDATING
Comment 10 Thomas Zander 2016-09-10 16:39:21 UTC
I have committed the UPDATING entry with modifications (wording) and changed author. Reason is that by convention a committer must be the author responsible for an UPDATING entry.