Bug 212529

Summary: security/tor: Added auto-creation of db and run, added warning about the tor2web option
Product: Ports & Packages Reporter: Yuri Victorovich <yuri>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed Overcome By Events    
Severity: Affects Only Me    
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch
yuri: maintainer-approval+
patch
yuri: maintainer-approval+
patch yuri: maintainer-approval+

Description Yuri Victorovich freebsd_committer freebsd_triage 2016-09-09 16:45:58 UTC 
Created attachment 174582 [details]
patch
Comment 1 Yuri Victorovich freebsd_committer freebsd_triage 2016-09-09 16:53:02 UTC 
Created attachment 174583 [details]
patch

Passes poudriere on 10.3 amd64.

This update:
1. Adds a warning about the expert option 'tor2web'.
2. Adds auto-creation of db and run directories during the service startup.
Comment 2 Yuri Victorovich freebsd_committer freebsd_triage 2016-09-09 16:55:25 UTC 
Created attachment 174584 [details]
patch
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-13 19:31:01 UTC 
Creating dirs from rc.d script is an antipattern. You can create them from the port and set permissions and owner in pkg-plist. This is already done for /var/run/tor, for instance.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-10-05 18:47:59 UTC 
Ping
Comment 5 Yuri Victorovich freebsd_committer freebsd_triage 2016-10-05 20:03:30 UTC 
Dmitry,

You are right, it's better to do this in pkg-list.

I integrated these changes into the 0.2.8.8 update: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=212952

Please commit it.

Thanks!