Bug 212594

Summary: [PATCH] games/manaplus: Update to 1.6.9.10
Product: Ports & Packages Reporter: Thibault Payet <monwarez>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me Keywords: patch
Priority: ---    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
manaplus diff
none
the new diff none

Description Thibault Payet 2016-09-12 04:34:32 UTC 
Created attachment 174670 [details]
manaplus diff

It pass QA (portlint, poudriere)
here poudriere log: https://gitlab.com/monwarez/FreeBSD-ports-poudriere-log/blob/master/manaplus/102amd64-manaplus-1.6.9.10.log

After a talk with 4144, it appears that autoreconf should be run ( to have a ./work/configure script that will fit the building system).

So now autoreconf will be run.
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-13 20:47:56 UTC 
Does not build with disabled NLS:

===>  Configuring for manaplus-1.6.9.10
Can't exec "autopoint": No such file or directory at /usr/local/share/autoconf-2.69/Autom4te/FileUtils.pm line 345.
autoreconf-2.69: failed to run autopoint: No such file or directory
autoreconf-2.69: autopoint is needed because this package uses Gettext
*** Error code 1
Comment 2 Thibault Payet 2016-09-13 22:48:50 UTC 
Created attachment 174754 [details]
the new diff

Ok then we need to have autopoint, which is provided by gettext-tools.
So we need to have gettext in USES. If one day, autopoint is alone, then we will not need to depend to gettext-tools when not using NLS.
The poudriere logs are here
https://gitlab.com/monwarez/FreeBSD-ports-poudriere-log/blob/master/manaplus/102amd64-manaplus-1.6.9.10.log
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-16 23:52:55 UTC 
Unconditional USES=gettext is not really needed, just NLS_USE_OFF=gettext-tools is enough, and it doesn't bring in unneeded runtime dependency.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-09-16 23:53:43 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Sep 16 23:52:51 UTC 2016
New revision: 422287
URL: https://svnweb.freebsd.org/changeset/ports/422287

Log:
  - Update to 1.6.9.10

  PR:		212594
  Submitted by:	monwarez@mailoo.org (maintainer)

Changes:
  head/games/manaplus/Makefile
  head/games/manaplus/distinfo
  head/games/manaplus/pkg-plist