Bug 212634

Summary: editors/mg: Update to latest snapshot
Product: Ports & Packages Reporter: Tobias Kortkamp <tobik>
Component: Individual Port(s)Assignee: Olivier Duchateau <olivierd>
Status: Closed FIXED    
Severity: Affects Only Me CC: darcsis, olivierd
Priority: --- Keywords: patch
Version: LatestFlags: bugzilla: maintainer-feedback? (darcsis)
Hardware: Any   
OS: Any   
Attachments:
Description Flags
mg.diff
none
mg.diff tobik: maintainer-approval? (darcsis)

Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-09-12 21:58:59 UTC
Created attachment 174698 [details]
mg.diff

- Update to latest snapshot 20160912
- Remove 2 patches by including OpenBSD's reallocarray instead of replacing it with realloc
- The port doesn't use gmake, so the GNUmakefile patch can be removed. It was added in ports r420741 for unknown reasons

Portlint ok, Poudriere testport FreeBSD 10.3/amd64 ok

Since there have been 3 maintainer timeouts in the past I'm offering to take maintership.
Comment 1 Olivier Duchateau freebsd_committer freebsd_triage 2016-09-12 22:21:34 UTC
(In reply to Tobias Kortkamp from comment #0)

reallocarray(3) exists since 11.0-PRERELEASE, patch is for system < 11.0, see my update #212487
Comment 2 Tobias Kortkamp freebsd_committer freebsd_triage 2016-09-12 22:40:56 UTC
Created attachment 174699 [details]
mg.diff

Urrgh, sorry for not checking if there is an open bug for mg already.

I've updated the patch to only include reallocarray.c on FreeBSD < 11.0.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-06 19:51:52 UTC
A commit references this bug:

Author: olivierd
Date: Thu Oct  6 19:51:20 UTC 2016
New revision: 423435
URL: https://svnweb.freebsd.org/changeset/ports/423435

Log:
  - Update to 20160912 snapshot
  - Remove GNUmakefile patch, port doesn't use gmake
  - Replace patches by another, when reallocarray(3) is missing
  - Pass maintainership to submitter
  - Add LICENSE
  - Update pkg-descr

  PR:		212634
  Submitted by:	Tobias Kortkamp
  Approved by:	<darcsis@gmail.com> (previous maintainer, timeout > 3 weeks)

Changes:
  head/editors/mg/Makefile
  head/editors/mg/distinfo
  head/editors/mg/files/extra-patch-def.h
  head/editors/mg/files/patch-GNUmakefile
  head/editors/mg/files/patch-Makefile
  head/editors/mg/files/patch-autoexec.c
  head/editors/mg/files/patch-def.h
  head/editors/mg/files/patch-display.c
  head/editors/mg/files/reallocarray.c
  head/editors/mg/pkg-descr
Comment 4 Olivier Duchateau freebsd_committer freebsd_triage 2016-10-06 19:53:53 UTC
Committed with minor changes.

def.h patch is only necessary when reallocarray(3) is missing in libc.