Bug 212667
| Summary: | [PATCH] machdep.c: check DDB_ENABLED before defining SPR/db_show_table | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Base System | Reporter: | Kenneth Salerno <kennethsalerno> | ||||
| Component: | kern | Assignee: | Justin Hibbits <jhibbits> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | jhibbits, ngie | ||||
| Priority: | --- | Keywords: | patch | ||||
| Version: | CURRENT | ||||||
| Hardware: | powerpc | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Take. A commit references this bug: Author: jhibbits Date: Wed Sep 14 23:24:23 UTC 2016 New revision: 305820 URL: https://svnweb.freebsd.org/changeset/base/305820 Log: Only define db_show_spr if DDB is enabled. PR: 212667 Reported by: Kenneth Salerno <kennethsalerno_AT_yahoo_dot_com> Changes: head/sys/powerpc/powerpc/machdep.c Thanks for the report, I just committed an equivalent fix (the right macro is "DDB", not "DDB_ENABLED"). |
Created attachment 174741 [details] patch to check if ddb is enabled in kernel before defining debugger commands In reference to this change last month: r304051 | jhibbits | 2016-08-13 14:46:49 -0400 (Sat, 13 Aug 2016) | 21 lines Add a kdb show command to print arbitrary SPRs on PowerPC ----------------------------------------------------------------------------- The attached patch checks first if DDB is enabled in the kernel configuration before defining db_show_table (DB_SHOW_COMMAND(spr, db_show_spr)). The behavior before this patch is a powerpc/powerpc64 kernel with DDB disabled fails to link with an undefined reference to db_show_table.