Summary: | [MAINTAINER] net-mgmt/collectd5: update to 5.6.0 | ||||||
---|---|---|---|---|---|---|---|
Product: | Ports & Packages | Reporter: | Krzysztof <ports> | ||||
Component: | Individual Port(s) | Assignee: | Joseph Mingrone <jrm> | ||||
Status: | Closed FIXED | ||||||
Severity: | Affects Many People | CC: | amdmi3, jrm, kbowling, swills | ||||
Priority: | --- | Flags: | ports:
maintainer-feedback+
|
||||
Version: | Latest | ||||||
Hardware: | Any | ||||||
OS: | Any | ||||||
Attachments: |
|
Description
Krzysztof
2016-09-19 21:07:13 UTC
importance change The build fails on 9i386 and 9amd64. disk.c:663: error: 'DSM_TOTAL_BUSY_TIME' undeclared (first use in this function) depbase=`echo utils_cmd_putval.lo | sed 's|[^/]*$|.deps/&|;s|\.lo$||'`;\ disk.c:663: error: (Each undeclared identifier is reported only once disk.c:663: error: for each function it appears in.) disk.c:664: error: 'DSM_TOTAL_DURATION' undeclared (first use in this function) Could you add a 9-specific patch for the problematic block in disk.c? OK, I will try. On my testing poudriere disk.c patch was rejected. For me it seems that whole patch was introduced to collectd sources... So I've made an investigation. I can see that this plugin is depending on /usr/include/devstat.h which is absent at 9.x system? Unfortunatelly I have no 9.x box, so I'm not able to reproduce this error. I can see that whole previous patch of disk.c file is added to disk.c file. So I don't know how to "repair" :-((( Also I've not found any patch for FreeBSD 9.x version. Any suggestions? FreeBSD 9 lifecycle is almost complete, I'd suggest disabling the disk plugin with --enable-disk passed to autoconf. (In reply to Kevin Bowling from comment #5) To clarify --disable-disk just for FreeBSD < 10 OK, so we can close this PR? A commit references this bug: Author: jrm Date: Mon Sep 26 14:52:00 UTC 2016 New revision: 422778 URL: https://svnweb.freebsd.org/changeset/ports/422778 Log: Update net-mgmt/collectd5 to version 5.6.0 - new port options CHRONY and MQTT - disable disk plugin on FreeBSD 9.x due to missing OS files - various patch changes PR: 212832 Submitted by: ports@bsdserwis.com (maintainer) Reviewed by: swills (mentor) Approved by: swills (mentor) Differential Revision: https://reviews.freebsd.org/D8028 Changes: head/net-mgmt/collectd5/Makefile head/net-mgmt/collectd5/distinfo head/net-mgmt/collectd5/files/patch-Makefile.am head/net-mgmt/collectd5/files/patch-configure.ac head/net-mgmt/collectd5/files/patch-src__Makefile.am head/net-mgmt/collectd5/files/patch-src__daemon__Makefile.am head/net-mgmt/collectd5/files/patch-src__daemon__collectd.h head/net-mgmt/collectd5/files/patch-src__dns.c head/net-mgmt/collectd5/files/patch-src__modbus.c head/net-mgmt/collectd5/files/patch-src_config.h.in head/net-mgmt/collectd5/files/patch-src_disk.c head/net-mgmt/collectd5/files/patch-src_write__mongodb.c head/net-mgmt/collectd5/files/patch-src_zfs__arc.c head/net-mgmt/collectd5/files/patch-version-gen.sh head/net-mgmt/collectd5/pkg-plist Committed (with minor changes). Thanks! |