Bug 212876

Summary: re(4): Add support for NCube 8168 network cards
Product: Base System Reporter: Tobias Kortkamp <tobik>
Component: kernAssignee: freebsd-bugs (Nobody) <bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: gosha-necr, kevlo, net
Priority: --- Keywords: patch
Version: CURRENTFlags: tobik: mfc-stable11?
tobik: mfc-stable10?
Hardware: Any   
OS: Any   
URL: https://forums.freebsd.org/threads/57734/
Attachments:
Description Flags
if_re.diff tobik: maintainer-approval? (net)

Description Tobias Kortkamp freebsd_committer freebsd_triage 2016-09-21 07:43:25 UTC
Created attachment 175029 [details]
if_re.diff

User goshanecr on the forums has a Realtek 8168 based which identifies itself as

03:00.0 Ethernet controller: NCube Device 8168 (rev 06)
class=0x020000 card=0x34687470 chip=0x816810ff rev=0x06 hdr=0x00

which is currently not recognized by re(4).  Adding a new entry to re_devs seems to be all that is needed to support this card.  See the forum thread for more details.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-09-21 14:15:29 UTC
A commit references this bug:

Author: kevlo
Date: Wed Sep 21 14:15:16 UTC 2016
New revision: 306102
URL: https://svnweb.freebsd.org/changeset/base/306102

Log:
  Add support for the TP-Link TG-3468 v2.

  This is an RTL8168 chip, which we already support so all we have to do is add
  the vendor ID.

  PR:	212876
  Submitted by:	Tobias Kortkamp <t@tobik.me>
  MFC after:	3 days

Changes:
  head/share/man/man4/re.4
  head/sys/dev/re/if_re.c
  head/sys/dev/rl/if_rlreg.h
Comment 2 Kevin Lo freebsd_committer freebsd_triage 2016-09-21 14:17:37 UTC
Committed as r306102 with minor modifications, thanks.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-09-25 13:53:42 UTC
A commit references this bug:

Author: kevlo
Date: Sun Sep 25 13:52:56 UTC 2016
New revision: 306309
URL: https://svnweb.freebsd.org/changeset/base/306309

Log:
  MFC r306102:

  Add support for the TP-Link TG-3468 v2.
  This is an RTL8168 chip, which we already support so all we have to do is add
  the vendor ID.

  PR:	212876
  Submitted by:	Tobias Kortkamp <t@tobik.me>

Changes:
_U  stable/11/
  stable/11/share/man/man4/re.4
  stable/11/sys/dev/re/if_re.c
  stable/11/sys/dev/rl/if_rlreg.h