Bug 212901
| Summary: | sysutils/lsof fails to build on base/head after r305902 | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Trond Endrestøl <Trond.Endrestol> | ||||||||||||
| Component: | Individual Port(s) | Assignee: | Adam Weinberger <adamw> | ||||||||||||
| Status: | Closed FIXED | ||||||||||||||
| Severity: | Affects Many People | CC: | adamw, ler | ||||||||||||
| Priority: | --- | Flags: | ler:
maintainer-feedback+
|
||||||||||||
| Version: | Latest | ||||||||||||||
| Hardware: | Any | ||||||||||||||
| OS: | Any | ||||||||||||||
| Attachments: |
|
||||||||||||||
I will run this by Vic Abell (author). I had sent him mail, but he didn't know when he would get to it. Created attachment 175063 [details]
make makepatch version of the patch
Created attachment 175064 [details]
make makepatch version of the patch
Created attachment 175065 [details]
port upgrade patch
I did a test compile, and it works, I regenerated the patch using make makepatch, after removing the DOS line-ends. Committer: Please be aware of adding the patch. Please hold off on this, Vic says the patch won't work, and is working on a new one. Created attachment 175076 [details]
upgrade patch to 4.90G
Vic Abell generated a new release (4.90G) to cope with this, upgrade attached.
Hi Larry, I'm watching the thread here but it's your show. Keep doing what you're doing, and when you're ready, tell me to commit it. Also, if Trond's patch is no longer relevant, please mark it as obsolete. Comment on attachment 175061 [details]
Patch for dialects/freebsd/dnode.c
this patch is obsolete.
Sorry, forgot that you might not be able to mark someone else's patch as obsolete. Please commit the 4.90G version which is the official fix. I couldn't mark Trond's obsolete, BZ wouldn't take it :( A commit references this bug: Author: adamw Date: Thu Sep 22 21:51:48 UTC 2016 New revision: 422641 URL: https://svnweb.freebsd.org/changeset/ports/422641 Log: Update to 4.90G. Includes: - Change from using i_dev to using i_ump->um_dev PR: 212901 Submitted by: Trond Endrestol Approved by: maintainer (Larry Rosenman) Changes: head/sysutils/lsof/Makefile head/sysutils/lsof/distinfo (In reply to Larry Rosenman from comment #11) Done. Thanks for that patch, Trond! Larry, can you look into getting lsof to acknowledge the "make test" target? |
Created attachment 175061 [details] Patch for dialects/freebsd/dnode.c Change from using i_dev to using i_ump->um_dev. See attached patch.