Bug 212951
| Summary: | devel/visualparadigm: Update to 13.2 build 20160904 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Fernando Apesteguía <fernape> | ||||||||
| Component: | Individual Port(s) | Assignee: | Ben Woods <woodsb02> | ||||||||
| Status: | Closed Overcome By Events | ||||||||||
| Severity: | Affects Some People | CC: | woodsb02 | ||||||||
| Priority: | --- | Flags: | fernape:
maintainer-feedback+
|
||||||||
| Version: | Latest | ||||||||||
| Hardware: | Any | ||||||||||
| OS: | Any | ||||||||||
| See Also: | https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213211 | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 175272 [details]
Patch to update devel/visualparadigm to 13.2.20160904
Hi Fernando,
Apologies for not having this done already. I have some further improvements over your patch that I want to suggest, but I have been unable to perform build testing due to problems building the dependency java/openjdk8 (see PR213088).
Regardless, can you please consider the attached patch, and let me know your thoughts? In summary:
- Adds LICENSE details, which are quite restrictive regarding redistribution
- Set the WRKSRC to the directory the distfile will be extracted into (inline with other ports)
- Install into ${DATADIR} instead of /usr/local/visualparadigm. Not that for java ports, ${DATADIR} is typically set to /usr/local/share/java/visualparadigm
- Use ${INSTALL_PROGRAM} in Makefile to install binaries that need to be executable, rather than @mode 0755 in pkg-plist. Note I haven't implemented this one yet - but I will once I can do build testing.
(In reply to Ben Woods from comment #1) Hi Ben, Thanks for taking time to improve this port. I'm fine with all your changes. I changed the install target to use INSTALL_SCRIPT (as opposed to INSTALL_PROGRAM) since the files you refer to are actually scripts. I could test build it since I have openjdk8 compiled from a week ago. - Q/A * portlint -AC OK * port test OK * poudriere builds for {9.3,10.1,10.2,10.3}{i386,amd64} OK I uploaded the poudriere logs in case you want to have a look: https://app.box.com/s/bujip0990dwrtccll1zsbwchninsus52 Created attachment 175288 [details]
patch to the ports tree
This PR has been deprecated by this new one: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=213211 |
Created attachment 175109 [details] patch to the ports tree The attached patch updates devel/visualparadigm to version 13.2 build 20160904. The upstream project doesn't provide details for minor updates - Q/A: * port test: OK * portlint -AC: OK * poudriere builds for {9.3,10.1,10.2,10.3}{i386,amd64}: OK